Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI test: random master tokens #394

Closed
fredrikhgrelland opened this issue Oct 13, 2020 · 1 comment · Fixed by #448 or Skatteetaten/vagrant-hashistack-template#85
Closed

CI test: random master tokens #394

fredrikhgrelland opened this issue Oct 13, 2020 · 1 comment · Fixed by #448 or Skatteetaten/vagrant-hashistack-template#85
Assignees
@claesgill @dangernil
Labels
theme/ci Related to build, test, and release pipeline theme/test Related to testing
Milestone
0.9.0

Comments

@fredrikhgrelland
Copy link
Contributor

after 0.6.0 master tokens for vault, consul and nomad are all set using custom environvariables vault_master_token consul_master_token nomad_master_token. We should test that these are used throughout by generating random values and using them in the CI tests.
@fredrikhgrelland fredrikhgrelland added theme/test Related to testing theme/ci Related to build, test, and release pipeline labels Oct 13, 2020
@zhenik zhenik added this to the 0.7.0 milestone Oct 13, 2020
@pdmthorsrud
Copy link
Contributor

Suggestion from meeting(Nikita): do this via env_override in actions

This was referenced Oct 21, 2020
Merged
Closed
@Neha-Sinha2305 Neha-Sinha2305 mentioned this issue Oct 22, 2020
Merged
5 tasks
@zhenik zhenik modified the milestones: 0.7.0, 0.8.0 Nov 2, 2020
@dangernil dangernil mentioned this issue Nov 12, 2020
Merged
5 tasks
@claesgill claesgill mentioned this issue Nov 19, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claesgill claesgill

@dangernil dangernil

Labels
theme/ci Related to build, test, and release pipeline theme/test Related to testing
Projects
None yet
Milestone
0.9.0
5 participants
@zhenik @claesgill @fredrikhgrelland @pdmthorsrud @dangernil