Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre and post_ansible.sh supplied by the box are never run. #438

Closed
3 tasks done
pdmthorsrud opened this issue Nov 3, 2020 · 0 comments · Fixed by #442
Closed
3 tasks done

pre and post_ansible.sh supplied by the box are never run. #438

pdmthorsrud opened this issue Nov 3, 2020 · 0 comments · Fixed by #442
Assignees
Labels
type/bug Something isn't working
Milestone

Comments

@pdmthorsrud
Copy link
Contributor

What is the issue?

We have two shell-scripts, example.pre_ansible.sh and example.post_ansible.sh, that is inside the /ansible/files/bootstrap/ folder. These are never run anywhere, and putting any pre_ansible.sh file in the directory would not do anything. There is no point for these files to be where they are. On top of that they are put inside /etc/ansible in the box, which makes it even less ideal of a place, because they have nothing to do with ansible (and they wouldn't be called from there either).

Suggestion(s)/solution(s) [Optional]

Remove them. We already have a system in place where shell-scripts inside /dev will be run.

Checklist (after created issue)

  • Added label(s)
  • Added to project
  • Added to milestone
@pdmthorsrud pdmthorsrud added the type/bug Something isn't working label Nov 3, 2020
@pdmthorsrud pdmthorsrud self-assigned this Nov 3, 2020
@pdmthorsrud pdmthorsrud mentioned this issue Nov 5, 2020
5 tasks
@zhenik zhenik added this to the 0.7.1 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants