Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest version 3 update checklist #19

Closed
6 tasks done
Skeletonxf opened this issue May 18, 2022 · 3 comments
Closed
6 tasks done

Manifest version 3 update checklist #19

Skeletonxf opened this issue May 18, 2022 · 3 comments

Comments

@Skeletonxf
Copy link
Owner

Skeletonxf commented May 18, 2022

  • Duplicate Tab uses a persistent background page, this will need migrating to a non persistent one. Duplicate Tab has very little state in that background page so this should be straightforward.
  • Browser action APIs have changed namespace. Since the APIs are the same this should be a trivial update.
  • This migration is a good opportunity to adopt newer JavaScript language features than ES6: async/await/??/?.
  • The minimum supported Firefox version will need increasing to whatever version of FF ships MV3 first, regardless of which version this is, it should be more than new enough for adopting modern JavaScript language features.
  • Session storage comes in at FF 115, this is the absolute minimum to port all functionality without risking stale tab ID bugs
  • Revisit [Feature] Move tab to new window #14?
  • [ ] Revisit [Feature] Duplicate & back? #8 (it may be possible by combining executeScript with history.back())
@Skeletonxf
Copy link
Owner Author

Skeletonxf commented Feb 28, 2023

  • Update normal duplication
  • Update advanced duplication
  • Update settings UI
  • Update automated dismissing the advanced duplication tab UI
  • Update permissions UI in advanced duplication tab
  • Test on Firefox for Android to make sure everything still works there
  • Delete all the replaced code

@Skeletonxf
Copy link
Owner Author

Future version

@Skeletonxf
Copy link
Owner Author

Closing this issue as the addon is updated to MV3 and all problems with that update are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant