Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1-Forge] [Change Items Durability Mod] | Even though I set the mode setting in the config file on the server, it is not updated on the client. #298

Closed
2 tasks done
TeQTabanca opened this issue Nov 16, 2024 · 27 comments

Comments

@TeQTabanca
Copy link

Bug description

Even though I set the mode setting in the config file on the server, it is not updated on the client.

Steps to reproduce

  1. Download Change Items Durability Mod
  2. There is changeitemsdurability.conf file inside the server config file, by default shield item durability is set to 5. Set its durability to 100 or 1000 and save.
  3. Start the server and check the durability of the shield item.

Expected behavior

The changeitemsdurability.conf file needs to be updated according to the server.

Actual behavior

No response

Relevant logs

No response

Minecraft & Mod Loader versions

1.20.1-47.3.11

Minecraft launcher

No response

Operating system

Windows 11

AutoModpack version

automodpack-mc1.20.1-forge-4.0.0-beta18

Other information

No response

Check list

  • I have verified that the issue persists in the latest version of the mod.
  • I have searched the existing issues and confirmed that this is not a duplicate.
@Skidamek
Copy link
Owner

Skidamek commented Nov 16, 2024

Please test if this issue exists if you remove automodpack from your server. If it does, report to them, if it does not please send your automodpack-content.json file and latest related logs from client and sever.

@TeQTabanca
Copy link
Author

TeQTabanca commented Nov 16, 2024

Please test if this issue exists if you remove automodpack from your server. If it does, report to them, if it does not please send your automodpack-content.json file and latest related logs from client and sever.

The problem still persists.

automodpack-content.json

Logs

Logs (Automodpack mod installed.)

@suerion
Copy link
Contributor

suerion commented Nov 16, 2024

is the config file in an folder? or where is it?

@TeQTabanca
Copy link
Author

is the config file in an folder? or where is it?

in config file

@suerion
Copy link
Contributor

suerion commented Nov 16, 2024

@TeQTabanca where is the server? did you have the server on windows 11? or is this in an dedicated server?

@TeQTabanca
Copy link
Author

@TeQTabanca where is the server? did you have the server on windows 11? or is this in an dedicated server?

I'm testing on Windows 11

@suerion
Copy link
Contributor

suerion commented Nov 16, 2024

Change the config file, and try to delete automodpack-content.json. in the servers automodpack folder

After this, send please the new generatet automodpack-content file, then, try to connect with client, and see if the config is changed in /automodpack/host...../config/

@TeQTabanca
Copy link
Author

TeQTabanca commented Nov 16, 2024

Change the config file, and try to delete automodpack-content.json. in the servers automodpack folder

After this, send please the new generatet automodpack-content file, then, try to connect with client, and see if the config is changed in /automodpack/host...../config/

Automodpack is trying to update but the problem still persists because the config file is in the main config.

automodpack-content.json

@suerion
Copy link
Contributor

suerion commented Nov 16, 2024

Okey,

    {
      "file": "/config/changeitemsdurability.conf",
      "size": "100",
      "type": "config",
      "editable": true,
      "sha1": "15ff29587d5a06490115c2c095ab9ff95abaf451",
      "murmur": null
    }

Did you have the latest log from the client? because it will try to change the config. but something went wrong.

and send also please the automodpack-server.json from the server

i think we will find the issue ;)

Did you close also the Launcher or only Minecraft?

@Skidamek
Copy link
Owner

But according to that mod curseforge page, that mod allows you to change tool durability server side, you don't need sync server config to client, you only just need to make sure you have that mod on client and on server. If it doesn't work like so, report to them

@TeQTabanca
Copy link
Author

Okey,

    {
      "file": "/config/changeitemsdurability.conf",
      "size": "100",
      "type": "config",
      "editable": true,
      "sha1": "15ff29587d5a06490115c2c095ab9ff95abaf451",
      "murmur": null
    }

Did you have the latest log from the client? because it will try to change the config. but something went wrong.

and send also please the automodpack-server.json from the server

i think we will find the issue ;)

Did you close also the Launcher or only Minecraft?

automodpack-server.json

Client log

@TeQTabanca
Copy link
Author

But according to that mod curseforge page, that mod allows you to change tool durability server side, you don't need sync server config to client, you only just need to make sure you have that mod on client and on server. If it doesn't work like so, report to them

The problem is when it is not updated the item drops to -value and is not deleted from the inventory.

@TeQTabanca
Copy link
Author

I looked for such mods but couldn't find any. There is a synchronization problem in this mode, AutomodPack mode also has a synchronization feature, but I think it cannot update the .conf files.

@Skidamek
Copy link
Owner

It can, automodpack can update anything actually

@suerion
Copy link
Contributor

suerion commented Nov 16, 2024

But according to that mod curseforge page, that mod allows you to change tool durability server side, you don't need sync server config to client, you only just need to make sure you have that mod on client and on server. If it doesn't work like so, report to them

The problem is when it is not updated the item drops to -value and is not deleted from the inventory.

On Client
Try to delete in the automodpack/host/

The complete folder of the hosted modpack and try to download it again, important is, that you delete automodpack_content.json

And then send first modpack update latest.log and then send after starting minecraft the latest.log

If there is a issue on syncing the config file.

But as Skidam writed, it does not need the config on client side

@Skidamek
Copy link
Owner

Skidamek commented Nov 16, 2024

Remove /config/* form editable files, that will make sure to have all of your configs always synced to the sever version

@suerion
Copy link
Contributor

suerion commented Nov 16, 2024

Yeah thats the issue, because it is there already,

It does not overwrite the config anymore becaus all config files are editable,

If there was no config file there, it does sync the file from server.

Then, this brings me to an sugfestion @Skidamek could you add an option to download on first sync and then it is editable?

Because i will send options.txt to the clients. And it should editable. Could there an option, to overwrite some files and rhen it should be editable?

@Skidamek
Copy link
Owner

Then, this brings me to an sugfestion @Skidamek could you add an option to download on first sync and then it is editable?
Because i will send options.txt to the clients. And it should editable. Could there an option, to overwrite some files and rhen it should be editable?

That's how it should work, you sure it doesn't do it already? I remember fixing it like half a year ago to achieve that behavior. If it's broken please create new issue.

@TeQTabanca
Copy link
Author

But according to that mod curseforge page, that mod allows you to change tool durability server side, you don't need sync server config to client, you only just need to make sure you have that mod on client and on server. If it doesn't work like so, report to them

The problem is when it is not updated the item drops to -value and is not deleted from the inventory.

On Client Try to delete in the automodpack/host/

The complete folder of the hosted modpack and try to download it again, important is, that you delete automodpack_content.json

And then send first modpack update latest.log and then send after starting minecraft the latest.log

If there is a issue on syncing the config file.

But as Skidam writed, it does not need the config on client side

Client Log

@TeQTabanca
Copy link
Author

Remove /config/* form editable files, that will make sure to have all of your configs always synced to the sever version

I tried and still have the same problem.

@suerion
Copy link
Contributor

suerion commented Nov 16, 2024

Remove /config/* form editable files, that will make sure to have all of your configs always synced to the sever version

I tried and still have the same problem.

On your client log, it shows this

[16Kas2024 20:56:34.852] [main/INFO] [AutoModpack/]: Overwriting /config/changeitemsdurability.conf file to the modpack version

Try to look again on your server, if you had changed the config there,

Or send me your server setup to see whats your problem?

(Zip file on wetransfer or something)

I will check it here.

It looks like it should work

What i need: on server automodpack, config and mods folder

@TeQTabanca
Copy link
Author

Remove /config/* form editable files, that will make sure to have all of your configs always synced to the sever version

I tried and still have the same problem.

On your client log, it shows this

[16Kas2024 20:56:34.852] [main/INFO] [AutoModpack/]: Overwriting /config/changeitemsdurability.conf file to the modpack version

Try to look again on your server, if you had changed the config there,

Or send me your server setup to see whats your problem?

(Zip file on wetransfer or something)

I will check it here.

It looks like it should work

What i need: on server automodpack, config and mods folder

1.20.1-Forge.zip

@suerion
Copy link
Contributor

suerion commented Nov 16, 2024

image
You don't need the folder, delete it, in this folder there is the config file, that file overwrite the config files again

automodpack-server.json
Use this Automodpack setting, it sync the complet config folder from server config

  "syncedFiles": [
    "/mods/*.jar",
    "/config/*",
    "!/mods/iDontWantThisModInModpack.jar",
    "!/config/andThisConfigToo.json",
    "!/mods/andAllTheseMods-*.jar",
    "!/mods/server-*.jar"
  ],
  "allowEditsInFiles": [
    "/options.txt",
    "!/config/excludeThisFile"
  ],

Try it again

@TeQTabanca
Copy link
Author

image You don't need the folder, delete it, in this folder there is the config file, that file overwrite the config files again

automodpack-server.json Use this Automodpack setting, it sync the complet config folder from server config

  "syncedFiles": [
    "/mods/*.jar",
    "/config/*",
    "!/mods/iDontWantThisModInModpack.jar",
    "!/config/andThisConfigToo.json",
    "!/mods/andAllTheseMods-*.jar",
    "!/mods/server-*.jar"
  ],
  "allowEditsInFiles": [
    "/options.txt",
    "!/config/excludeThisFile"
  ],

Try it again

Synchronization was achieved by adding the "/config/*" text to the "syncedFiles" property. So there is no need to add any .conf file to the main folder. Thanks for your help. It seems like such a setting should be made default when you release the new version.

@suerion
Copy link
Contributor

suerion commented Nov 16, 2024

It is not an issue, it is because, you could change all settings for the client to sync, if you do, you could do.

if some other don't need to sync config files, it is okey.

Only for an little looking on other configs, here is mine
automodpack-server.json

i exclude some server sided mods, because a lot of mod devs forget to give the server sided oder client side tag.

only some edits are allowed, because i will give all settings for the modpack.

@suerion
Copy link
Contributor

suerion commented Nov 16, 2024

But, it works now for you, you could close your issue, if i or @Skidamek could help you again, add an new issue

and, if you will add only client sided mods, you could use the main folders
image

Then it would only sync the files to the client without loading on server side. ;)

@TeQTabanca
Copy link
Author

But, it works now for you, you could close your issue, if i or @Skidamek could help you again, add an new issue

and, if you will add only client sided mods, you could use the main folders image

Then it would only sync the files to the client without loading on server side. ;)

I'm already adding client-side modes here. Some client-side mods do not work on the server side, but when I put them in the main folder, there is no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants