Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions with blocks return differently when the looped stuff isn't a variable #2175

Closed
TPGamesNL opened this issue Jun 18, 2019 · 3 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@TPGamesNL
Copy link
Member

Description

The solid condition doesn't work in loops when the given values to loop aren't variables (this is a terrible description but you should look at Steps to Reproduce, it's more understandable).
Same for: is transparent, is flammable

Steps to Reproduce

on rightclick on sand with diamond hoe:
	loop block above and block below:
		message "&21 &r%loop-value% (%""&atrue"" if loop-value is solid, else (""&cfalse"")%&r)"
	set {_b::*} to block above and block below
	loop {_b::*}:
		message "&32 &r%loop-value% (%""&atrue"" if loop-value is solid, else (""&cfalse"")%&r)"

image

Expected Behavior

The condition should return true or false consistently in both loops.

Server Information

  • Server version/platform: Paper-94 (1.14.2)
  • Skript version: 2.4-alpha3
@TheBentoBox TheBentoBox added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Jul 8, 2019
@TheBentoBox
Copy link
Member

Well that's weird.

@Whimsyturtle
Copy link
Member

Will try and investigate this later

@Whimsyturtle
Copy link
Member

Oddly enough, I found that this was caused due to the internal use of ItemStack, hence this issue is fixed by #2510

@Whimsyturtle Whimsyturtle added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

3 participants