Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs Glow Example #2518

Closed
APickledWalrus opened this issue Oct 4, 2019 · 2 comments
Closed

Docs Glow Example #2518

APickledWalrus opened this issue Oct 4, 2019 · 2 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. documentation Related to Skript's official documentation. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@APickledWalrus
Copy link
Member

APickledWalrus commented Oct 4, 2019 •
edited
Loading

Description

The example code for the glow expression errors.

Steps to Reproduce

Try and run the example code. It will error.

Expected Behavior

The example should be updated or it should be made possible to write the expression in the shown way.

set glowing of player on doesn't work
set glowing of player to on works

Errors / Screenshots

image
image
image

Server Information

  • Server version/platform: git-paper-191 (MC: 1.14.4) (18 versions behind)
  • Skript version: 2.4-beta7 (I know it's not the latest but the I do not think the bug would be fixed)
@Whimsyturtle Whimsyturtle mentioned this issue Oct 5, 2019
Closed
@Whimsyturtle Whimsyturtle added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. documentation Related to Skript's official documentation. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Oct 9, 2019
@Whimsyturtle Whimsyturtle mentioned this issue Oct 10, 2019
Merged
@Whimsyturtle Whimsyturtle added the completed The issue has been fully resolved and the change will be in the next Skript update. label Oct 10, 2019
@APickledWalrus
Copy link
Member Author

This issue is good to be closed now.

@Whimsyturtle
Copy link
Member

This is in the 2.4-beta10 release but for some reason is not in the 2.4 branch... will close when it is added there.

@Whimsyturtle Whimsyturtle reopened this Dec 22, 2019
@bensku bensku closed this as completed Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. documentation Related to Skript's official documentation. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bensku @Whimsyturtle @APickledWalrus