-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Names and lores of books are being ignored #2900
Comments
can you try 2.5-alpha3.... I believe this issue has already been resolved. |
Yes, should be resolved in 2.5-alpha2. (#2714) |
Seems to be fixed but when checking for an item with multiple lores, it seems to cause internal error. For example when you add this: command /removebook:
trigger:
set {_book} to amount of book named "Test" with lore "Testing book" and "t" in player's inventory This worked fine in 2.4.1, not sure if this is a problem related to #2714 or I should open another issue. Console Error: https://pastebin.com/H3xyhp4H One way to bypass this is to only check for one lore line or not at all, may be an issue if someone needs to check multiple lore lines. |
Hello, I can confirm this problem in 2.5-alpha3. command /givetest:
trigger:
give a book named "This is a test." with lore "Hello!" and "Wow!" to player
command /test:
trigger:
set {_lore::*} to "Hello!" and "Wow!"
set {_book} to amount of book named "This is a test." with lore {_lore::*} in player's inventory
send "%{_book}%" |
I just tested this using 1.12.2 and 1.16.1 with Skript 2.5-beta1 and the issue seems to have been resolved somewhere along the way. |
Description
Named books are being ignored when checking for names/lores.
Steps to Reproduce
Expected Behavior
After doing /testbook, player will contain one vanilla book and one named "Test with lore "Testing book", when /removebook is executed, the vanilla book should stay in player's inventory and one "testing" book should be removed, but instead, the vanilla book will be removed and the testing one will stay.
Errors / Screenshots
No errors
Server Information
Additional Context
The text was updated successfully, but these errors were encountered: