Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

particle offsets not working #2958

Closed
DampfWaffel opened this issue May 2, 2020 · 4 comments
Closed

particle offsets not working #2958

DampfWaffel opened this issue May 2, 2020 · 4 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls.

Comments

@DampfWaffel
Copy link

Hello,
i've experienced some Bugs with the play/show effect

but it seems the when im discover one, im not able to Reproduce it every time.

first, the offset are not working. its spawn just a single point at the given loaction and the loading time for offsets are huge.
second, when i want more particles e.g play 10 firework spark ... it just do nothing or throw an error.
third, i think the endRod Particle is missing.

Steps to Reproduce

first, play firework spark with offset of 100, 40, 100 and speed 0 on player to player
second, play 10 firework spark on player to player

Errors / Screenshots

first, https://cdn.discordapp.com/attachments/645017130651222058/706107655160332388/7kRW5rT2OM.gif
second, https://pastebin.com/dkpSXzhs

Server Information

  • Server version/platform: Paper version git-Paper-161 (MC: 1.15.2)
  • Skript version: Skript version 2.5-alpha3

Grats

@ShaneBeee
Copy link
Contributor

Skript's effect for particles does not have an offset option:
http://skriptlang.github.io/Skript/effects.html#EffVisualEffect

My guess is you are using an add-on for this effect

@DampfWaffel
Copy link
Author

DampfWaffel commented May 2, 2020

ah that was quick,
i found this offset at the SkriptHub Docs.
http://i.epvpimg.com/I3NXeab.png

area_expression: [with [offset of %number%, %number%(,| and) %number%][[and ]speed %number%]]

and when i'm changing the speed it applies to the particle

@ShaneBeee
Copy link
Contributor

Interesting, I didn't know that existed.
I'll mark this as needs investigating.

@ShaneBeee ShaneBeee added the needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. label May 2, 2020
@legofreak1999
Copy link

legofreak1999 commented May 14, 2020

I can't test but it think this is not a bug but an syntax misperception.

There is a difference between visual effects and particles.

In the syntax u write "on player" so skript thinks u want to play a visual effect from the entity player.
so like love hearts of a dog. But some effects are bound to specific entitys and a player has no effect of firework spark. So i think the parser parses the code for the location but doesn't register that its using now a location instead of an entity and since play on has no propertys for offset it doesn't work.

In short terms try this syntax:

play firework spark with offset of 100, 40, 100 and speed 0 at location of player to player

play 10 firework spark at location of player to player

@ShaneBeee ShaneBeee added the completed The issue has been fully resolved and the change will be in the next Skript update. label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls.
Projects
None yet
Development

No branches or pull requests

3 participants