Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player name cannot be compared with owner #3344

Closed
SlimeDog opened this issue Aug 28, 2020 · 4 comments
Closed

Player name cannot be compared with owner #3344

SlimeDog opened this issue Aug 28, 2020 · 4 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@SlimeDog
Copy link

Description

Player name in previously accepted skript is not recognized. The skript ran without error through Skript 2.5-beta2.

Steps to Reproduce

  • Update from Skript 2.5-beta2 to 2.5-beta3.
  • Start server.
  • Obverse console/log error.

Note that the real player name has been replaced below by "playerName".

Errors / Screenshots

[15:50:10] [Server thread/INFO]: [Skript] Loading Skript v2.5-beta3
[15:50:27] [Server thread/INFO]: [Skript] Enabling Skript v2.5-beta3
...
[15:51:35] [Server thread/INFO]: [Skript] Loading variables...
[15:51:35] [Server thread/INFO]: [Skript] Loaded 7 variables in 0.0 seconds
...
[15:51:40] [Server thread/ERROR]: [Skript] Can't compare an inventory holder with a text (save-my-pets.sk, line 38: owner of the victim is "playerName"')
[15:51:40] [Server thread/ERROR]: [Skript] Can't compare an inventory holder with a text (save-my-pets.sk, line 54: owner of the victim is "playerName"')

Server Information

  • Server version/platform: Spigot 1.16.2 (Jenkins 2897)
  • Skript version: 2.5-beta3

Additional Context

The skript

on damage of a cat:
        owner of the victim is "playerName"
        cancel event
        send "Don't hurt that cat!" to the attacker
        attacker is not "playerName"
...
@ShaneBeee
Copy link
Contributor

Hot diggity, you fix one bug and create another haha.

Anyways the inventory (holder|owner) expression and the (owner|tamer) expression are clashing.
Until I can fix this, use tamer instead.

@SlimeDog
Copy link
Author

tamer works fine. Thanks.

@ShaneBeee ShaneBeee added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Aug 28, 2020
@SlimeDog SlimeDog changed the title Player name not recognized Player name cannot be compared with owner Aug 29, 2020
@SlimeDog
Copy link
Author

SlimeDog commented Aug 29, 2020

Per documentation:

The tamer of an entity. Can only be used in entity tame events. 

Nevertheless, it appears to work fine in the quoted comparison, which is not an entity tame event. So perhaps the documentation needs an update.

@ShaneBeee
Copy link
Contributor

2 different expressions:
Screen Shot 2020-08-28 at 5 17 36 PM
Screen Shot 2020-08-28 at 5 17 57 PM

This was simply a clash with:
Screen Shot 2020-08-28 at 4 52 45 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

2 participants