Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Colors Persistent #5176

Open
1 task done
AlexStavrev opened this issue Oct 22, 2022 · 3 comments
Open
1 task done

Make Colors Persistent #5176

AlexStavrev opened this issue Oct 22, 2022 · 3 comments
Labels
core task Tasks that may be handled only by the core developer team. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@AlexStavrev
Copy link

Suggestion

Make the color type persistent allowing it to be saved in variables. Currently it isn't and leads to the following behavior:
image

Why?

Is there a reason why this is not the case? I understand it for inventories and entities, but I can't imagine why a color is not persistent.

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@Fusezion
Copy link
Contributor

Wait what? They aren't? Wth.

@TheLimeGlass
Copy link
Contributor

Colours are implemented by multiple classes because, chat colour, Skript colour, RGB, hex etc. It can easily be implemented. When it was recoded, the serialization was probably forgotten. There is really no reason to not support serialization other than backwards compatibility will break the variable for hex values when downgrading Skript version.

@TheLimeGlass TheLimeGlass added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Oct 22, 2022
@TheLimeGlass
Copy link
Contributor

SkriptColor is an enum where as ColorRGB is a class and Color is an interface and that means SkriptColor cannot be instansiated for deserializating. Requires API changes.

@TheLimeGlass TheLimeGlass added the core task Tasks that may be handled only by the core developer team. label Dec 28, 2022
@TheLimeGlass TheLimeGlass changed the title Make Colors Persistent | Discussion Make Colors Persistent Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core task Tasks that may be handled only by the core developer team. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

3 participants