You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I cant seem to use sk info cause of the error but its:
Skript 2.9.4/.5
Skbee: 3.6.3
Paper 1.21.1 Latest Build
Bug Description
So i removed every vanilla enchantment using new "filter" thingy (datapacks), skript didnt have any problems untill i added few ones back like Riptide, Unbreaking, Multishot thats when it showed the error, same thing happens if you create atleast 1 custom one, like if there are 0 registered enchantments for skript, skript has no issues but if there skript registers atlesst 1 enchantment, it starts checking for every vanilla enchantment ig and thats probably why it crashes
Expected Behavior
So it shouldnt show the error and skript should work, datapack that i made worked with skript normally but after adding few enchantments back cause i didnt want to remove every one of them skript suddenly showed an error and stopped working and disabled itself, it shouldnt just disable skript, and the vanilla enchantments should work with skript cause normally when i only added effickency enchantment back it worked and skript could check for it but for example: sharpness didnt work and that was the whole point to make almost every one of enchantments just dont exist it worked fine untill skript showed the errors and disables itself
Steps to Reproduce
I created a custom datapack and in pack.mcmeta i filtered "enchantment" folder { "pack": { "description": "Learn to Make Custom Enchantments!", "pack_format": 48 }, "filter": { "block": [{ "namespace": "minecraft", "path": "enchantment" }] } }
thats the code i have in pack.mcmeta it removes every enchantment
to add few enchantments back i created folders in the datapack so it should look like this:
data > minecraft > enchantment and in this folder you create files like: vanishing_curse.json efficiency.json
for example i'll give the code for efficiency.json: { "anvil_cost": 1, "description": { "translate": "enchantment.minecraft.efficiency" }, "effects": { "minecraft:attributes": [ { "amount": { "type": "minecraft:levels_squared", "added": 1.0 }, "attribute": "minecraft:player.mining_efficiency", "id": "minecraft:enchantment.efficiency", "operation": "add_value" } ] }, "max_cost": { "base": 51, "per_level_above_first": 10 }, "max_level": 5, "min_cost": { "base": 1, "per_level_above_first": 10 }, "slots": [ "mainhand" ], "supported_items": "#minecraft:enchantable/mining", "weight": 10 }
and for riptide.json: { "anvil_cost": 4, "description": { "translate": "enchantment.minecraft.riptide" }, "effects": { "minecraft:trident_sound": [ "minecraft:item.trident.riptide_1", "minecraft:item.trident.riptide_2", "minecraft:item.trident.riptide_3" ], "minecraft:trident_spin_attack_strength": { "type": "minecraft:add", "value": { "type": "minecraft:linear", "base": 1.5, "per_level_above_first": 0.75 } } }, "exclusive_set": "#minecraft:exclusive_set/riptide", "max_cost": { "base": 50, "per_level_above_first": 0 }, "max_level": 3, "min_cost": { "base": 17, "per_level_above_first": 7 }, "slots": [ "hand" ], "supported_items": "#minecraft:enchantable/trident", "weight": 2 }
and this is it
Errors or Screenshots
Other
If you guys could fix this or atleast tell me how to fix it i would really appreciate it.
Agreement
I have read the guidelines above and affirm I am following them with this report.
The text was updated successfully, but these errors were encountered:
Yep i found the answer, skript checks for enchantments but once it feels that something is wrong it requires every enchantment i added the protection as it showed in the error then it told me to add fire protection and then its just every enchantment prob
erenkarakal
added
bug
An issue that needs to be fixed. Alternatively, a PR fixing an issue.
and removed
bug
An issue that needs to be fixed. Alternatively, a PR fixing an issue.
labels
Nov 26, 2024
Skript likely assumes every vanilla enchantment already exists which needs to be fixed. Also your datapack is wrong, it should be "minecraft:mining_efficiency" not "minecraft:player.mining_efficiency"
I had to fix that to recreate the issue, maybe because I'm on 1.21.3
LisooYT
changed the title
Datapacks | Removing Enchantments error?
Datapacks | Removing Enchantments error/Skript Crash
Dec 31, 2024
LisooYT
changed the title
Datapacks | Removing Enchantments error/Skript Crash
Skript Crashes When Removing enchantments and adding new custom ones
Jan 1, 2025
Skript/Server Version
Bug Description
So i removed every vanilla enchantment using new "filter" thingy (datapacks), skript didnt have any problems untill i added few ones back like Riptide, Unbreaking, Multishot thats when it showed the error, same thing happens if you create atleast 1 custom one, like if there are 0 registered enchantments for skript, skript has no issues but if there skript registers atlesst 1 enchantment, it starts checking for every vanilla enchantment ig and thats probably why it crashes
Expected Behavior
So it shouldnt show the error and skript should work, datapack that i made worked with skript normally but after adding few enchantments back cause i didnt want to remove every one of them skript suddenly showed an error and stopped working and disabled itself, it shouldnt just disable skript, and the vanilla enchantments should work with skript cause normally when i only added effickency enchantment back it worked and skript could check for it but for example: sharpness didnt work and that was the whole point to make almost every one of enchantments just dont exist it worked fine untill skript showed the errors and disables itself
Steps to Reproduce
I created a custom datapack and in pack.mcmeta i filtered "enchantment" folder
{ "pack": { "description": "Learn to Make Custom Enchantments!", "pack_format": 48 }, "filter": { "block": [{ "namespace": "minecraft", "path": "enchantment" }] } }
thats the code i have in pack.mcmeta it removes every enchantment
to add few enchantments back i created folders in the datapack so it should look like this:
data > minecraft > enchantment and in this folder you create files like: vanishing_curse.json efficiency.json
for example i'll give the code for efficiency.json:
{ "anvil_cost": 1, "description": { "translate": "enchantment.minecraft.efficiency" }, "effects": { "minecraft:attributes": [ { "amount": { "type": "minecraft:levels_squared", "added": 1.0 }, "attribute": "minecraft:player.mining_efficiency", "id": "minecraft:enchantment.efficiency", "operation": "add_value" } ] }, "max_cost": { "base": 51, "per_level_above_first": 10 }, "max_level": 5, "min_cost": { "base": 1, "per_level_above_first": 10 }, "slots": [ "mainhand" ], "supported_items": "#minecraft:enchantable/mining", "weight": 10 }
and for riptide.json:
{ "anvil_cost": 4, "description": { "translate": "enchantment.minecraft.riptide" }, "effects": { "minecraft:trident_sound": [ "minecraft:item.trident.riptide_1", "minecraft:item.trident.riptide_2", "minecraft:item.trident.riptide_3" ], "minecraft:trident_spin_attack_strength": { "type": "minecraft:add", "value": { "type": "minecraft:linear", "base": 1.5, "per_level_above_first": 0.75 } } }, "exclusive_set": "#minecraft:exclusive_set/riptide", "max_cost": { "base": 50, "per_level_above_first": 0 }, "max_level": 3, "min_cost": { "base": 17, "per_level_above_first": 7 }, "slots": [ "hand" ], "supported_items": "#minecraft:enchantable/trident", "weight": 2 }
and this is it
Errors or Screenshots
Other
If you guys could fix this or atleast tell me how to fix it i would really appreciate it.
Agreement
The text was updated successfully, but these errors were encountered: