Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in biomes #73

Closed
Pilvinen opened this issue May 5, 2016 · 2 comments
Closed

Errors in biomes #73

Pilvinen opened this issue May 5, 2016 · 2 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.

Comments

@Pilvinen
Copy link

Pilvinen commented May 5, 2016

I went through and tested all the biomes with //setbiome and then tested what Skript shows as the biome:

command /biometest:
  trigger:
    send " Biome: %biome at location of player%" to player

I found some errors:

In the Spigot javadocs in biomes enum the code shows having both "jungle_hills" and "mutated_jungle".

//setbiome mutated_jungle ---> results in Skript showing the biome as jungle hills.
//setbiome jungle_hills ---> results in Skript showing the biome as nothing.

//setbiome mutated_mesa -> results in Skript showing the biome as “Hoodoos” I have never read of it or heard of it. Is this correct? Shouldn't it be "Mesa (Bryce)"?

//setbiome mutated_mesa_clear_rock ---> result in Skript showing the biome as nothing.
//setbiome mutated_mesa_rock ---> result in Skript showing the biome as nothing.

//setbiome roofed_forest_hills ---> result in Skript showing the biome as "biomes.roofed_forest_hills" (missing support).

//setbiome redwood_taiga_hills ---> result in Skript showing the biome as "biomes.META_taiga_hills", ie. missing support/spelling error (meta instead of mega).

//setbiome void ---> result in Skript showing the biome as "void biome", which I'm not sure if it's intentional or not.

AFAIK all the rest of the biomes were working properly unless I missed something.

@bensku
Copy link
Member

bensku commented May 6, 2016

Mutated mesa is due to Skript having wrong order in lang file entry. Should have checked that earlier...

@bensku bensku added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label May 6, 2016
@bensku
Copy link
Member

bensku commented May 6, 2016

Fixed in next release.

@bensku bensku closed this as completed May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

No branches or pull requests

2 participants