Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velocity expression not working and docs issues #792

Closed
1 of 5 tasks
Snow-Pyon opened this issue Aug 13, 2017 · 7 comments
Closed
1 of 5 tasks

Velocity expression not working and docs issues #792

Snow-Pyon opened this issue Aug 13, 2017 · 7 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. documentation Related to Skript's official documentation. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@Snow-Pyon
Copy link

Snow-Pyon commented Aug 13, 2017

So, I was gonna try some stuff with this expression and realized that it doesn't have any type value, that means you can't get the velocity from anywhere therefore it throws a NullPointerException.

Now, here are some issues with the current documentation:

  • This expression doesn't have the correct "since" value, it's "INSERT VERSION" right now:
    http://bensku.github.io/Skript/expressions.html#ExprVelocity

  • The world, tree type, time, timeperiod, timespan, experience, item type, item/material, number and enchantment type classinfos has some html tags around it.

  • The potion effect type classinfo has null between its values.

  • The enchantment classinfo has enchantments.names.sweeping_edge between its values.

  • The direction, command sender, entity type with amount and living entity classinfos has a href tag in the pattern.

@bensku
Copy link
Member

bensku commented Aug 13, 2017

Oooops, I probably merged this pull request a bit too fast, as it had some other useful features. @Snow-Pyon please post the NPE here fully. I hope @Sashie takes a look at it before next release, as I'm kinda busy.

Docs issues are something that I'll need to check. Thanks for reporting them.

@bensku bensku added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. docs labels Aug 13, 2017
@Snow-Pyon
Copy link
Author

Well, I think my memory didn't serve me right, it wasn't a NPE, it was an IndexOutOfBoundsException. Here is it anyways:
https://gist.github.com/Snow-Pyon/c44641627b2a33c37942c5f58f92ff26

@JeepSmash
Copy link
Contributor

More doc issues:
Every expression/condition/event/etc with a link in its description is Broken. 404 error for every link i could find in the docs

@bensku
Copy link
Member

bensku commented Aug 14, 2017

@Snow-Pyon Try without addons...

@Snow-Pyon
Copy link
Author

Snow-Pyon commented Aug 14, 2017

@bensku the addons doesn't matter, it's clearly an issue of Skript as how the velocity expression is being registered. A pull request has been made to fix this anyways.

@bensku
Copy link
Member

bensku commented Aug 15, 2017

The thing is, addons can override expressions with their own, so if an addon had velocity expressions, it might break stuff. But anyway, doesn't seem to be the cause in this case.

@bensku bensku removed the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Aug 25, 2017
@bensku bensku closed this as completed Sep 3, 2017
@bensku bensku reopened this Sep 3, 2017
@Snow-Pyon Snow-Pyon added priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. labels Jan 31, 2018
@Nicofisi Nicofisi added documentation Related to Skript's official documentation. and removed docs-issue labels Oct 27, 2018
@TheBentoBox
Copy link
Member

I believe this has been fixed long ago by now. At least, I personally have used the velocity expression without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. documentation Related to Skript's official documentation. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

5 participants