Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using go-git for Go operations #13

Open
rnorth opened this issue Apr 8, 2021 · 3 comments
Open

Switch to using go-git for Go operations #13

rnorth opened this issue Apr 8, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rnorth
Copy link
Collaborator

rnorth commented Apr 8, 2021

Break the dependency on execing the git command, and use https://github.com/go-git/go-git instead.

@rnorth rnorth added the enhancement New feature or request label Apr 8, 2021
@rnorth rnorth mentioned this issue Apr 8, 2021
@rnorth rnorth added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 14, 2021
@rnorth rnorth removed the good first issue Good for newcomers label Apr 26, 2021
@lanwen
Copy link
Contributor

lanwen commented Jun 7, 2021

Just as a wish which is often ignored (or got forgotten) - commit signature. Git binary picks it up currently automatically, however with go-git additional implementation would be required to handle it during commits.

@sledigabel
Copy link
Contributor

excellent remark @lanwen -- something to keep in mind.

@kurtmckee
Copy link
Contributor

kurtmckee commented Sep 12, 2023

Yep, strongly agree with @lanwen here. I sign my commits and tags and have verified signatures enabled on GitHub.

I advocate to just use git as-is so I can anticipate that my settings are inherited, and that a bug in an alternative implementation doesn't introduce repo corruptions that git fsck will complain about. For example, the Flask repo (with 64k stars on GitHub) already contains corruptions that have side effects when git's fsck is enabled:

# The clone below will exit with a fatal error due to zero-padded file modes.
git clone https://github.com/pallets/flask --config fetch.fsckobjects=true

It's possible for git clients to introduce repo corruptions. I recommend continuing to use vanilla git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants