Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"New serial device detected" pops up for non ESP devices #694

Closed
TheDevMinerTV opened this issue May 20, 2023 · 2 comments · Fixed by #756
Closed

"New serial device detected" pops up for non ESP devices #694

TheDevMinerTV opened this issue May 20, 2023 · 2 comments · Fixed by #756
Assignees
@ImUrX
Labels
Area: GUI Related to the GUI Type: Bug Something isn't working
Milestone
SlimeVR v1.0

Comments

@TheDevMinerTV
Copy link
Member

Somewhere between v0.6.8 and v0.7.1 a bug got introduced, that the "New serial device detected" popup appears for non ESP devices, for example my keyboard. This is really annoying because it happens every time I restart the server or reconnect my keyboard.
@TheDevMinerTV TheDevMinerTV added Type: Bug Something isn't working Area: GUI Related to the GUI labels May 20, 2023
@TheDevMinerTV TheDevMinerTV added this to the SlimeVR v1.0 milestone May 20, 2023
@Eirenliel
Copy link
Member

Our system to choose which devices are slimes is very bad, we need better solutions than just to filter by device name.

@ImUrX
Copy link
Member

ImUrX commented May 29, 2023

Connected to #362, we need PID and VID tbh

@ImUrX ImUrX linked a pull request Jul 28, 2023 that will close this issue
Move serial communication to desktop subproject #756
Merged
@Eirenliel Eirenliel reopened this Jul 30, 2023
@ImUrX ImUrX closed this as completed Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ImUrX ImUrX

Labels
Area: GUI Related to the GUI Type: Bug Something isn't working
Projects
None yet
Milestone
SlimeVR v1.0
Development

Successfully merging a pull request may close this issue.

Move serial communication to desktop subproject ImUrX/SlimeVR-Server
3 participants
@Eirenliel @ImUrX @TheDevMinerTV