Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Program.cs #15

Open
Yousef-Majidi opened this issue Nov 16, 2023 · 2 comments
Open

Refactor Program.cs #15

Yousef-Majidi opened this issue Nov 16, 2023 · 2 comments

Comments

@Yousef-Majidi
Copy link
Contributor

I recently worked on adding some features to this project and identified a multiple refactor possibilities. For example, export-spaces and 'import-spaces' can be refactored into individual modules and their code can be further refactored into methods.

@Yousef-Majidi
Copy link
Contributor Author

if you agree, I could work on this slowly over the next few weeks. This will also make it easier to develop some unit testing for the core functionalities.

@frankkilcommins
Copy link
Member

It's a slight trade off at this point. I normally start from the outset with dependency injection and separation of concerns, but fir this project was weary of spending the additional time until ROI is more clear. Part of me is also enjoying the simple navigation.

That being said, if you're very eager and willing, feel free to start the refactor. You can also propose your changes before investing the time, if you would like feedback etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants