Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script manager serious bug #152

Open
pchris7489 opened this issue Mar 1, 2023 · 2 comments
Open

Script manager serious bug #152

pchris7489 opened this issue Mar 1, 2023 · 2 comments

Comments

@pchris7489
Copy link

Hello,

There is a serious bug in script manager

  1. Create a new script
  2. Type in the script : echo 'hello world'
  3. Or type in the script : echo "hello world\n"
  4. Save the script

The bug : Smart Pack will absorb the quotes and the new line character, and the script will become either : echo hello world
Or : echo "hello world
"

Expected behavior : if you open this last saved script, you must see either : echo 'hello world'
Or : echo "hello world\n"

This bug can bring serious boot loop issues if someone saves a script to modify kernel settin-s and this bugs shows up

@pchris7489 pchris7489 reopened this Mar 1, 2023
@sunilpaulmathew
Copy link
Contributor

@pchris7489
I'll have a look on it, though I still don't know how it bootloops (may be my because of my limited knowledge).

@pchris7489
Copy link
Author

Well the data passed to the kernel will be invalid.

This happens only when saving a script in SP tought, it is a problem in SP, it seems that it doesn't escape special caracters before saving a script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants