Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix system repeat rate #62

Merged
merged 2 commits into from
Jan 27, 2019
Merged

Fix system repeat rate #62

merged 2 commits into from
Jan 27, 2019

Conversation

trimental
Copy link
Contributor

@trimental trimental commented Jan 27, 2019 •
edited
Loading

This was a mistake I made when implementing the key repetition. The delay should be milliseconds but the repeat rate is repeats per second.

from wayland docs:
rate | the rate of repeating keys in characters per second
delay | delay in milliseconds since key down until repeating starts

Thanks to @e00E for catching this bug

@trimental trimental mentioned this pull request Jan 27, 2019
Closed
@e00E
Copy link

e00E commented Jan 27, 2019

That looks like the same place I identified as well. Should also change documentation at line 364 to in characters per second instead of in milliseconds.

@trimental
Copy link
Contributor Author

@e00E good spot, thanks

@e00E e00E mentioned this pull request Jan 27, 2019
Closed
@elinorbgr
Copy link
Member

Thanks!

@elinorbgr elinorbgr merged commit 312f8b7 into Smithay:master Jan 27, 2019
@trimental trimental deleted the fix-repeat-rate branch January 28, 2019 02:56
linkmauve added a commit to glfw/glfw that referenced this pull request Feb 20, 2019
@linkmauve
Wayland: keyboard repeat rate is given in Hz
5f9cbd0 
It was currently interpreted as ms, which is obviously wrong.

Thanks to Smithay/client-toolkit#62 for making
me notice this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trimental @e00E @elinorbgr