-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control buttons #4
Comments
(I can mentor anyone who would be willing to attack this but is not familiar enough with wayland) |
Sounds interesting. I have no clue how this works 😜 |
(sorry for the late answer, I was away from computer) The rough idea here is that wayland does not handle decorations, so we are forced to draw them oursleves. This means there are a few substeps to this:
The wayland-specific stuff is mostly in the last part, for merging events generated by our decorations with events coming from the server. |
Okay, sounds like some work. I am setting up an Arch VM for the development, have not switched my main desktop to wayland. |
My current problem is funny/strange: I can not run the example. |
Oh well... This kind of issues occur way too often :( Can you run the example with the env variable |
A better solution would be to use server-side decorations for DEs that implement it. That's a wayland extension: https://cgit.kde.org/kwayland.git/tree/src/client/protocols/server-decoration.xml |
For now KDE is the only compositor to implement server-side decoration AFAIK. So yes, it'd be good to use them when available, but we still need to be able to draw our own. Client-side decoration is still the "official" way of doing it. |
Is this bug fixed? |
Basic control buttons exist with the latest version of wayland-window (which is used by the latest version of winit). So this can be closed, yeah. |
Add a "close" button on the upper-right corner, to close the window.
A "maximize/unmaximize" and "minimize" button can most likely be considered too.
The text was updated successfully, but these errors were encountered: