-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A simple alternative profile with a single config file #73
Comments
This is excellent!! I was having a hard time getting output/error logs working with the CookieCutter slurm configuration. It would default to slurm-######.out, even though it was configured in a seperate cluster_config.yml. Your config worked out of the box with minimal configuration. One question: is there anyway to change the log filenames for {wildcard}? I would like to not use "=" or "," in the filenames, so it doesn't require escaping to view. IE. less logs/trimmomatic_pe/trimmomatic_pe-sample=FA,unit=rep3-2687041.out Is there anyway to modify this behavior? |
@hans-vg Wonderful! The goal was minimal configuration, so I'm glad you were able to configure it quickly.
The But of course I would recommend you stick with the simple route. Yes those |
Hi @jdblischak, thanks for the post. Your repo looks really neat! Is there any functionality that could be merged with this profile? In any case, I can add a link in the README to your repo if you want, so that users don't have to browse the issue list to find it :) |
@percyfal Thanks! My initial inspiration came from your repo, so thank you for your efforts to document and maintain the official snakemake slurm profile.
The biggest difference in approach between the 2 profiles is how to specify default and per-rule resources. Your profile uses
That would be super appreciated. Thanks! |
@jdblischak I have added a link to your repo in #84. Also, I point out that the use of cluster-config is discouraged and that resources should be configured with snakemake CLI arguments in the profile configuration; in the end I don't think the difference between the two profiles is that great. I will still keep support for cluster-config for now, but probably deprecate it soon enough. One lingering issue that I have to deal with is increasing job submission speed as scalability is currently hampered. |
@percyfal Thanks so much!
I'm happy to help test this out. If you make some changes that affect the job submission speed, please ping me and I can run my job submission benchmark on the updated profile. |
The profile in this repo is very comprehensive and handles many different use cases. However, I was having difficulty customizing it, especially when I was trying to replicate the behavior of the deprecated
--cluster-config
option (see the discussion in #25).I've put together a simple profile that only requires you to download and edit a single
config.yaml
file:https://github.com/jdblischak/smk-simple-slurm
If you're having difficultly specifying options to pass to
sbatch
, e.g. including the rule name in the log filename, specifying different time limits per rule, etc., please give it a try. My simple template can solve previous issues in this repo without resorting to using the deprecated--cluster-config
option, e.g. #7, #24, #40, #42, #46The text was updated successfully, but these errors were encountered: