Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix sweepers #2800

Merged
merged 5 commits into from
May 15, 2024
Merged

fix: Fix sweepers #2800

merged 5 commits into from
May 15, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented May 15, 2024 •
edited
Loading

  • Bump timeout for integration tests
  • Use HasSuffix function in all the sweepers
  • Remove old conditional logic
  • Fix TestAcc_AccountRoles_basic test
  • Skip two use warehouse tests

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review May 15, 2024 07:28
@github-actions GitHub Actions
Copy link

Integration tests failure for 38ab8e8bebfb1f4b9ca0d29dfe7b9f0e48805b04

1 similar comment
@github-actions GitHub Actions
Copy link

Integration tests failure for 38ab8e8bebfb1f4b9ca0d29dfe7b9f0e48805b04

@sfc-gh-asawicki sfc-gh-asawicki merged commit a01115e into main May 15, 2024
9 of 10 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the fix-sweepers branch May 15, 2024 08:59
@snowflake-release-please snowflake-release-please bot mentioned this pull request May 15, 2024
Merged
sfc-gh-jmichalak pushed a commit that referenced this pull request May 16, 2024
@snowflake-release-please
chore(main): release 0.91.0 (#2791)
751e5d3 
🤖 I have created a release *beep* *boop*
---


##
[0.91.0](v0.90.0...v0.91.0)
(2024-05-16)


### 🎉 **What's new:**

* add snowflake_grant_application_role resource
([#2690](#2690))
([838d241](838d241))
* datasource database role
([#2731](#2731))
([319ddc3](319ddc3))


### 🔧 **Misc**

* Add few documentation adjustments
([#2789](#2789))
([6db8bf3](6db8bf3))
* Bump dependencies
([#2802](#2802))
([54ea6bc](54ea6bc))
* Replace parsing function for saving granted object names
([#2813](#2813))
([175cfc7](175cfc7))


### 🐛 **Bug fixes:**

* Fix sweepers
([#2800](#2800))
([a01115e](a01115e))
* Invoke SetId immediately after alert creation
([#2786](#2786))
([181b4d0](181b4d0))
* Update the tests after snowflake bugfix
([#2806](#2806))
([6843c1a](6843c1a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-asawicki @sfc-gh-jcieslak