Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add fully_qualified_name to all resources #2990

Merged
merged 7 commits into from
Aug 14, 2024
Merged

feat: Add fully_qualified_name to all resources #2990

merged 7 commits into from
Aug 14, 2024

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak commented Aug 12, 2024 •
edited
Loading

  • add fully_qualified_name to relevent resources
  • some resources had qualified_name already, so this field was removed in favor of the new one, with proper state migrators and acceptance tests
  • mention this in the migration guide - also with a list of not relevant resources

Test Plan

  • acceptance tests

References

@github-actions GitHub Actions
Copy link

Integration tests failure for d92d1a34e70db7a1eb0d0a9ff0584ffbdb2bbd6e

@gitguardian GitGuardian
Copy link

gitguardian bot commented Aug 12, 2024 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-jmichalak sfc-gh-jmichalak marked this pull request as ready for review August 12, 2024 14:31
@github-actions GitHub Actions
Copy link

Integration tests failure for 09183d0604a260e5a2be3d0363f8b028f3fdea2a

@github-actions GitHub Actions
Copy link

Integration tests failure for 713b060ad04d8b88b12e02ab818b5588d673f3eb

sfc-gh-jcieslak
sfc-gh-jcieslak requested changes Aug 13, 2024
View reviewed changes
MIGRATION_GUIDE.md Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
pkg/resources/database_acceptance_test.go Show resolved Hide resolved
pkg/resources/masking_policy.go Show resolved Hide resolved
pkg/resources/network_rule_state_upgraders.go Outdated Show resolved Hide resolved
pkg/resources/password_policy_acceptance_test.go Show resolved Hide resolved
pkg/resources/procedure.go Show resolved Hide resolved
pkg/resources/shared_database_acceptance_test.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests cancelled for 167f51c4ffc678d7c81a992c861fe0a27553580b

@github-actions GitHub Actions
Copy link

Integration tests failure for d3a7c066ba5286971c7ba6c2e7e98d35580df3c7

@github-actions GitHub Actions
Copy link

Integration tests failure for fc97d842554df7381c5e5b4ed5a2755d6b7920ad

@github-actions GitHub Actions
Copy link

Integration tests failure for 8805d1946a4afe605e2ef6fa3248dbdc0635e5c7

@github-actions GitHub Actions
Copy link

Integration tests failure for 1115344c1ed3a30a75286886d2a8df62ff3072b3

@sfc-gh-jmichalak sfc-gh-jmichalak merged commit 1b0462f into main Aug 14, 2024
8 of 9 checks passed
@snowflake-release-please snowflake-release-please bot mentioned this pull request Aug 14, 2024
Merged
sfc-gh-asawicki
sfc-gh-asawicki reviewed Aug 16, 2024
View reviewed changes
pkg/resources/common.go
@@ -8,6 +8,8 @@ import (
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

const FullyQualifiedNameAttributeName = "fully_qualified_name"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have now multiple places with common attribute names, maybe we should have common_attribute_names.go or something like this?

sfc-gh-jcieslak pushed a commit that referenced this pull request Sep 4, 2024
@snowflake-release-please
chore(main): release 0.95.0 (#2977)
cd1636c 
🤖 I have created a release *beep* *boop*
---


##
[0.95.0](v0.94.1...v0.95.0)
(2024-09-04)


### 🎉 **What's new:**

* Add change_tracking, row access policy and aggregation policy to views
([#2988](#2988))
([1f88bb1](1f88bb1))
* Add fully_qualified_name to all resources
([#2990](#2990))
([1b0462f](1b0462f))
* Add identifier parsers
([#2957](#2957))
([824ec52](824ec52))
* Add identifier with arguments
([#2979](#2979))
([00ae1c5](00ae1c5))
* Add timeouts block to cortex
([#3004](#3004))
([34d764b](34d764b))
* Add user parameters to resource
([#2968](#2968))
([f4ae380](f4ae380))
* Conclude user rework
([#3036](#3036))
([23e4625](23e4625))
* database role v1 readiness
([#3014](#3014))
([c4db255](c4db255))
* Identifier with arguments for procedure and external function
([#2987](#2987))
([f13cc5c](f13cc5c))
* Rework user resource
([#3026](#3026))
([bde2638](bde2638)),
closes
[#1572](#1572)
* Rework users datasource
([#3030](#3030))
([751239b](751239b)),
closes
[#2902](#2902)
* Upgrade view sdk
([#2969](#2969))
([ef2d50a](ef2d50a))
* View rework part 2
([#3021](#3021))
([e05377d](e05377d))
* View rework part 3
([#3023](#3023))
([195b41c](195b41c))


### 🔧 **Misc**

* Add annotation about fully_qualified_name and fix handling granteeName
([#3009](#3009))
([94e6345](94e6345))
* Apply identifier conventions
([#2996](#2996))
([5cbea84](5cbea84))
* apply identifier conventions to grants
([#3008](#3008))
([d7780ae](d7780ae))
* Clean collection utils
([#3028](#3028))
([426ddb1](426ddb1))
* Clean old assertions
([#3029](#3029))
([ad657eb](ad657eb))
* Conclude identifiers rework
([#3011](#3011))
([c1b53f3](c1b53f3))
* Improve user test and add manual test for user default database and
role
([#3035](#3035))
([6cb0b4e](6cb0b4e))
* Use new identifier with arguments in function, external function and
procedure grants
([#3002](#3002))
([5053f8b](5053f8b))
* User improvements
([#3034](#3034))
([65b64d7](65b64d7))


### 🐛 **Bug fixes:**

* database tests and introduce a new parameter
([#2981](#2981))
([3bae7f6](3bae7f6))
* Fix custom diffs for fields with diff supression
([#3032](#3032))
([2499602](2499602))
* Fix default secondary roles after BCR 2024_07
([#3040](#3040))
([2ca465a](2ca465a)),
closes
[#3038](#3038)
* Fix issues 2972 and 3007
([#3020](#3020))
([1772387](1772387))
* Fix known user resource issues
([#3013](#3013))
([a5dfeac](a5dfeac))
* identifier issues
([#2998](#2998))
([6fb76b7](6fb76b7))
* minor issues
([#3027](#3027))
([467b06e](467b06e)),
closes
[#3015](#3015)
[#2807](#2807)
[#3025](#3025)
* Nuke users
([#2971](#2971))
([0d90cc9](0d90cc9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki left review comments

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jmichalak @sfc-gh-jcieslak @sfc-gh-asawicki