feat: Row access policy resource v1 #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jmichalak
changed the title
sfc-gh-jcieslak
requested changes
Sep 11, 2024
sfc-gh-asawicki
requested changes
Sep 11, 2024
|
Integration tests failure for f16580c47ef57d8fb91e33d0fe2ee8460780e42f |
|
Integration tests failure for 145a0d069e3e8cc7677c26a46a7ee5cac526838a |
pkg/acceptance/bettertestspoc/config/model/row_access_policy_model_ext.go
Show resolved
Hide resolved
|
Integration tests failure for f67fe87e6d07933bb96a3a9729aba425541707e1 |
|
Integration tests failure for b9951a6afa1d861fe7d827af224c17411dd68b28 |
|
Integration tests failure for 6cbc5b0849b2f8f4edd82771d3d5a478eea12446 |
|
Integration tests failure for 6bfb6ed431c2e55f6e6241da32b679b7ae2930de |
sfc-gh-jcieslak
previously approved these changes
Sep 12, 2024
sfc-gh-asawicki
requested changes
Sep 12, 2024
|
Integration tests failure for 04df0b04525ef06d0c09b71ba6bebb1d4dafd976 |
|
Integration tests failure for 497b25e0184f1696bfc597228fac6c2e6e330dcc |
sfc-gh-asawicki
approved these changes
Sep 13, 2024
sfc-gh-fbudzynski
pushed a commit
that referenced
this pull request
Sep 19, 2024
<!-- Feel free to delete comments as you fill this in --> <!-- summary of changes --> - add show and desc output - rename fields - change signature to arguments - implement renaming - fix permadiff on body - adjust identifiers handling - adjust examples - gen resource asserts (config builders are not working because we have a required list argument) - improve handling data types - move parsing signature to sdk - support proper casing in arg names ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x] acceptance tests <!-- add more below if you think they are relevant --> * [ ] … ## References <!-- issues documentation links, etc --> https://docs.snowflake.com/en/sql-reference/sql/create-row-access-policy #2053 #1151 ## TODO (next PR) - rework data source
sfc-gh-jmichalak
pushed a commit
that referenced
this pull request
Sep 19, 2024
🤖 I have created a release *beep* *boop* --- ## [0.96.0](v0.95.0...v0.96.0) (2024-09-18) Essential GA object readiness for V1: [link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD) ([Roadmap reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#preparing-essential-ga-objects-for-the-provider-v1)). :exclamation: Migration guide: [v0.95.0 -> v0.96.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0950--v0960) ### 🎉 **What's new:** * V1 redesign of resources and data sources * Row access policy ([#3066](#3066)) ([#3063](#3063)) * Resource monitor ([#3052](#3052)) ([#3064](#3064)) * Masking policy ([#3078](#3078)) ([#3083](#3083)) * SDK upgrades * External volume ([#3033](#3033)) * Authentication policy ([#2937](#2937)) ([#3068](#3068)) ([#3061](#3061)) ### 🔧 **Misc** * Clean up old test object helpers ([#3049](#3049)) * Add example of granting role to multiple objects ([#3047](#3047)) * Update readme and objects rework state ([#3046](#3046)) ### 🐛 **Bug fixes:** * Fix model grants ([#3070](#3070)) * Fix database show by and resource logic ([#3055](#3055)) * Fix default secondary roles option import ([#3041](#3041)) * Fix sweepers for warehouse and database ([#3057](#3057)) * Fix views permadiff ([#3079](#3079)) * Update v0.95.0 migration guide ([#3062](#3062)) Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
References
https://docs.snowflake.com/en/sql-reference/sql/create-row-access-policy
#2053
#1151
TODO (next PR)