Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): separate public and private routes #576

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

rap2hpoutre
Copy link
Member

@rap2hpoutre rap2hpoutre commented Apr 4, 2022

Parce que sinon ça veut dire que tout le monde peut voir les stats orga par orga.

Le problème c'est que ça force à release l'app :/

@github-actions github-actions bot temporarily deployed to mano-separate-public-and-private-data April 4, 2022 15:32 Inactive
@arnaudambro
Copy link
Contributor

je vais garder les deux et merger et préparer une PR pour clean quand l'app sera déployée, ça sera plus simple, plus flex
et même si t'es contre, t'es pas là donc t'as tort ! haha 🥸

@github-actions github-actions bot temporarily deployed to mano-separate-public-and-private-data April 8, 2022 08:05 Inactive
@arnaudambro arnaudambro force-pushed the separate-public-and-private-data branch from dace170 to 8ffa8c5 Compare April 8, 2022 08:15
@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
47.5% 47.5% Duplication

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

🎉 Deployment for commit 8ffa8c5 :

Ingresses
Docker images
  • 📦 docker pull ghcr.io/socialgouv/docker/wait-for-postgres:6.56.1
  • 📦 docker pull ghcr.io/socialgouv/mano/api:sha-8ffa8c549df74b2e31d451f887a5fdb6432d955b
  • 📦 docker pull ghcr.io/socialgouv/mano/dashboard:sha-8ffa8c549df74b2e31d451f887a5fdb6432d955b
  • 📦 docker pull ghcr.io/socialgouv/mano/website:sha-8ffa8c549df74b2e31d451f887a5fdb6432d955b
Debug

@arnaudambro arnaudambro merged commit ea25259 into main Apr 8, 2022
@arnaudambro arnaudambro deleted the separate-public-and-private-data branch April 8, 2022 08:36
SocialGroovyBot added a commit that referenced this pull request Apr 8, 2022
# [1.87.0](v1.86.0...v1.87.0) (2022-04-08)

### Bug Fixes

* **security:** separate public and private routes ([#576](#576)) ([ea25259](ea25259))

### Features

* **app, dashboard:** action urgent ([#581](#581)) ([be93ee8](be93ee8))
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.87.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants