Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

feat: add validation errors on update psychologists #193

Merged
merged 1 commit into from
May 30, 2022
Merged

feat: add validation errors on update psychologists #193

merged 1 commit into from
May 30, 2022

Conversation

rap2hpoutre
Copy link
Member

@rap2hpoutre rap2hpoutre commented May 27, 2022 •
edited
Loading

J'ai mis un peu de temps mais ça m'a permis de découvrir le code ! Trois trucs :

  • Affichage du détail des erreurs (traduits/adaptés quand l'erreur "peut" vraiment arriver sans curl)
  • Validation de l'URL du site web doit commencer par http ou https
  • Validation de l'adresse grâce au format adresse déjà en place sur l'adresse principale (obligatoire) et la secondaire (optionnelle).

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot requested a deployment to mon-psy-sante-add-errors-when-input-is-invalid May 27, 2022 13:55 In progress
@github-actions github-actions bot requested a deployment to mon-psy-sante-add-errors-when-input-is-invalid May 27, 2022 15:13 In progress
@github-actions github-actions bot requested a deployment to mon-psy-sante-add-errors-when-input-is-invalid May 29, 2022 15:45 In progress
carolineBda
carolineBda approved these changes May 29, 2022
View reviewed changes
Copy link
Contributor

@carolineBda carolineBda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super l'utilisation de Joy pour l'adresse !

src/components/Admin/PsychologistForm.tsx
@@ -105,7 +106,11 @@ const PsychologistForm = ({
psychologist: Psychologist;
isSuperAdmin: boolean;
}) => {
const [result, setResult] = useState<{ type: string; text: string }>();
const [result, setResult] = useState<{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rap2hpoutre rap2hpoutre merged commit 37cdf92 into main May 30, 2022
@rap2hpoutre rap2hpoutre deleted the add-errors-when-input-is-invalid branch May 30, 2022 07:18
SocialGroovyBot added a commit that referenced this pull request May 30, 2022
@SocialGroovyBot
chore(release): version 1.35.0
fa93402 
# [1.35.0](v1.34.2...v1.35.0) (2022-05-30)

### Features

* **style:** improve breadcrumb ([#195](#195)) ([df30e41](df30e41))
* add validation errors on update psychologists ([#193](#193)) ([37cdf92](37cdf92))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carolineBda carolineBda carolineBda approved these changes

Assignees

@carolineBda carolineBda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rap2hpoutre @carolineBda