Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

fix(k8s): use external pg-user #68

Merged
merged 1 commit into from
Feb 22, 2022
Merged

fix(k8s): use external pg-user #68

merged 1 commit into from
Feb 22, 2022

Conversation

revolunet
Copy link
Member

@revolunet revolunet commented Feb 18, 2022 •
edited
Loading

Changes for kubernetes deployment :

  • rename .k8s to .socialgouv and adjust GH workflows (align with new socialgouv/actions defaults)
  • remove azure-pg-user sealed-secrets from the repo : is now provided by infra

@revolunet revolunet marked this pull request as ready for review February 18, 2022 17:15
carolineBda
carolineBda reviewed Feb 21, 2022
View reviewed changes
.github/workflows/review.yml
##############################################################################
## CREATE POSTGRES DATABASE
##############################################################################
create-db:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avant on a pas besoin de créer de db ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En fait avant le job de création de DB était inclus dans les "manifests" produits par l'application. On l'a extrait dans une action dédiée pour découpler cette partie, ca nous semble plus explicite;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍

@desoindx
Copy link
Contributor

Je me suis permis de modifier le nom du commit pour le faire passer.

@github-actions github-actions bot temporarily deployed to mon-psy-sante-db-secrets February 22, 2022 08:15 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@carolineBda
Copy link
Contributor

Le create DB a l'air de fail ? c'est rapport à la modif dont tu parlais @desoindx ?
cc @revolunet
Quand c'est green, si c'est ok pour vous, on merge comme ça je déploi en même temps qu'une autre branch que je vais déployer aujourd'hui comme ça on a pas de surprise plus tard

@github-actions github-actions bot temporarily deployed to mon-psy-sante-db-secrets February 22, 2022 13:25 Inactive
@github-actions
Copy link

🎉 Deployment for commit 64f4202 :

Ingresses
Docker images
  • 📦 docker pull ghcr.io/socialgouv/docker/wait-for-postgres:6.56.1
  • 📦 docker pull ghcr.io/socialgouv/mon-psy-sante/app:sha-64f420262ddc40ec46ed606ead5b49a722f39348
Debug

@revolunet
Copy link
Member Author

c'est fixé !

@carolineBda carolineBda merged commit 7b99dfb into main Feb 22, 2022
@carolineBda carolineBda deleted the db-secrets branch February 22, 2022 15:37
SocialGroovyBot added a commit that referenced this pull request Feb 22, 2022
@SocialGroovyBot
chore(release): version 1.12.3
23a7ed9 
## [1.12.3](v1.12.2...v1.12.3) (2022-02-22)

### Bug Fixes

* **k8s:** use external pg-user ([#68](#68)) ([7b99dfb](7b99dfb))
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.12.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carolineBda carolineBda carolineBda left review comments

@desoindx desoindx desoindx approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@revolunet @desoindx @carolineBda @SocialGroovyBot