New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units created after call to begin() never get their begin() called #105

Open

sofian opened this issue Feb 26, 2024 · 0 comments

Assignees

Labels

bug

Collaborator

sofian commented Feb 26, 2024

cf. PqCore.cpp:48-51
If I create a unit during of after call to PlaquetteEnv::begin() the unit's begin() function will never be called.

Could be fixed by using a boolean in PlaquetteEnv to tell us that begin has been (or is being) called. Then checking in Unit's constructor if the boolean checks out and acting accordingly.
Alternatively ... perhaps the Unit::begin() should be called in the postBegin() of PlaquetteEnv.

sofian added the bug label

sofian self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment