Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cache invalidation for regenerated videos #2

Open
jordimas opened this issue Nov 22, 2024 · 2 comments
Open

Implement cache invalidation for regenerated videos #2

jordimas opened this issue Nov 22, 2024 · 2 comments

Comments

@jordimas
Copy link
Contributor

When using get_file we return the "X-File-Revision" header with the revision number

This should be used to show the video then when you regenerate the video in the backend you can see the new video and not the cache version
@jordimas
Copy link
Contributor Author

I cannot reproduce this any more. I do not know why. I am closing it for now and I can reopen it in case it happens again.

@jordimas jordimas reopened this Dec 1, 2024
@jordimas
Copy link
Contributor Author

jordimas commented Dec 1, 2024

It happens sometimes but I could not find a way to reproduce it.

To be in the safe side, may be just to add the revision into the URL then it is only cached per revision

@jordimas jordimas mentioned this issue Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jordimas