-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOL-89741] Solace-binder not support instrument in SpringBoot 3.x && Spring Cloud 2022.x #219
Comments
#227 added support for Spring Boot |
I think what @desertTown means is something like this: https://github.com/micrometer-metrics/micrometer-samples/blob/main/kafka-producer/src/main/java/com/example/micrometer/ManualConfiguration.java#L20C28-L20C49 |
A proper solution would be to instrument Solace Spring Cloud Binder using the Micrometer Observation API. This means to run a Micrometer For example, the following commit implements the Micrometer observability instrumentation in spring-rabbit (which is at the base of spring-cloud-stream-binder-rabbit): Listener Observability Initial Commit. |
Hi Solace support,
we found that there no related span info send out to solace while we use SpringBoot version 3.x,
and SpringCloud Support Marcin Grzehszczak said That's a missing instrumentation in the solace binder. they have changed the way SC function gets instrumented. Function now instruments only the function itself and it's up to the binders to instrument the edges. If you're using Rabbit or Kafka binder these would be the instrumentations in Rabbit or Kafka - those should be automatically turned on by Spring Cloud Stream.
can I confirm if solace-binder support instrument in SpringBoot 3.x?
Thanks
The text was updated successfully, but these errors were encountered: