Skip to content
This repository has been archived by the owner on Apr 27, 2021. It is now read-only.

FP S4136 doesn't handle accessors correctly #469

Closed
saberduck opened this issue Jan 24, 2018 · 2 comments
Closed

FP S4136 doesn't handle accessors correctly #469

saberduck opened this issue Jan 24, 2018 · 2 comments
Assignees
@saberduck
Labels
false positive
Milestone
1.7

Comments

@saberduck
Copy link
Contributor

TSLint rule adjacent-overload-signatures doesn't handle properties correctly, it considers get set to be an overload.
@saberduck saberduck added this to the 1.6 milestone Jan 24, 2018
@saberduck saberduck self-assigned this Feb 14, 2018
@saberduck saberduck changed the title FP S4136 doesn't handle properties correctly FP S4136 doesn't handle accessors correctly Feb 14, 2018
@saberduck
Copy link
Contributor Author

PR created in tslint repository palantir/tslint#3718

@saberduck saberduck removed this from the 1.6 milestone Feb 15, 2018
@saberduck saberduck removed the ready label Feb 15, 2018
@vilchik-elena vilchik-elena added this to the 1.7 milestone Apr 30, 2018
@saberduck saberduck mentioned this issue May 16, 2018
Merged
@saberduck
Copy link
Contributor Author

saberduck commented May 16, 2018 •
edited
Loading

Reimplemented rule from tslint adjacent-overload-signatures with rule consecutive-overloads in sonarts to handle this FP

@saberduck saberduck removed the review label May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@saberduck saberduck

Labels
false positive
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
2 participants
@saberduck @vilchik-elena