Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# Plugin filters out tokens starting at EOL #8039

Closed
antonioaversa opened this issue Sep 21, 2023 · 0 comments · Fixed by #8046
Closed

C# Plugin filters out tokens starting at EOL #8039

antonioaversa opened this issue Sep 21, 2023 · 0 comments · Fixed by #8046
Assignees
@antonioaversa
Labels
Area: SQ Plugin Java plugin related issues.
Milestone
9.11

Comments

@antonioaversa
Copy link
Contributor

antonioaversa commented Sep 21, 2023 •
edited
Loading

Affects syntax highlighting in SonarQube and SonarCloud for both C# and razor files.
The regression was introduced between 9.9 and 9.10, during razor development.
Example on Peach: https://peach.sonarsource.com/code?id=mudblazor&selected=mudblazor%3AMudBlazor.SourceCodeGenerator%2FSourceCodeBuilder.cs

Wrong:
RawStringTokenization Peach Wrong

Correct:
image

The logic to filter out introduced during razor development needs to stay because of mapping issues on Roslyn side, caused by the following issues:

For an example of invalid tokens due to tabs used, see here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonioaversa antonioaversa

Labels
Area: SQ Plugin Java plugin related issues.
Projects
None yet
Milestone
9.11
Development

Successfully merging a pull request may close this issue.

C# Plugin filters out tokens starting at EOL SonarSource/sonar-dotnet
2 participants
@antonioaversa @costin-zaharia-sonarsource