Bug in SetOptionsOperation

[eugene3141]

stellar-php-sdk/Soneso/StellarSDK/SetOptionsOperation.php

Line 181 in 69a3894

if ($this->masterKeyWeight) {

It's impossible to set masterKeyWeight to 0. It should be

 if ($this->masterKeyWeight !== null) {
   $result->setMasterWeight($this->masterKeyWeight);
 }

[christian-rogobete]

Hello @eugene3141,
thank you for reporting this issue. I fixed it in release 1.0.2

[eugene3141]

https://onlinephp.io?s=s7EvyCjg5eLlUilLLFKwVTCwBnEy0zTAfEVbhbzSnBxNhWpeLs7U5Ix8BXUDmKA6UGUtqmLsqpGUAwA%2C&v=8.1.11

!= doesn't check type, so int 0 equals null, and the check fails.
It should be !== to force type check.

[christian-rogobete]

thx, it's strange because it worked in my test. I updated it in release 1.0.3.

[eugene3141]

Thank you.
In the test, you used assertEquals, it also doesn't check type.
assertSame checks type.

[christian-rogobete]

thank you