Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-notes): stop sending previously sent ones #1845

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

C0ZEN
Copy link
Member

@C0ZEN C0ZEN commented Nov 16, 2022

Fixes #1787

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated (for bugfix/feature)
  • Docs have been added/updated (for bugfix/feature)

PR Type

What kind of change does this PR introduce?

  • Feature (a new feature)
  • Bugfix (a bug fix)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • Refactor (a code change that neither fixes a bug nor adds a feature)
  • Perf (a code change that improves performance)
  • Test (adding missing tests or correcting existing tests)
  • Build (changes that affect the build system, CI configuration or external dependencies)
  • Docs (changes that affect the documentation)
  • Chore (anything else), please describe:

What is the current behaviour?

What is the new behaviour?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@C0ZEN C0ZEN added bug Something isn't working enhancement Add a new feature/enhancement labels Nov 16, 2022
@C0ZEN C0ZEN added this to the v2.0.0 milestone Nov 16, 2022
@C0ZEN C0ZEN self-assigned this Nov 16, 2022
@github-actions github-actions bot added the test Contains a change in a test file label Nov 16, 2022
@C0ZEN C0ZEN added the merge-into-master Will create a PR from develop to master label Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1845 (1e9e46e) into develop (fc6c568) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1845   +/-   ##
========================================
  Coverage    96.86%   96.86%           
========================================
  Files          352      352           
  Lines         8030     8034    +4     
  Branches       829      830    +1     
========================================
+ Hits          7778     7782    +4     
  Misses         252      252           
Flag Coverage Δ
integration 96.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rebase/enums/guilds/firebase-guild-version.enum.ts 100.00% <ø> (ø)
...s/has-firebase-guild-last-release-notes-version.ts 100.00% <ø> (ø)
...uilds/firebase-guilds-new-version-count.service.ts 100.00% <ø> (ø)
...ices/guilds/firebase-guilds-new-version.service.ts 99.52% <100.00%> (+<0.01%) ⬆️

@C0ZEN C0ZEN merged commit c2deaaf into develop Nov 16, 2022
@C0ZEN C0ZEN deleted the feature/release-notes branch November 16, 2022 21:00
@Sonia-corporation-bot
Copy link
Contributor

🎉 This PR is included in version 1.99.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Sonia-corporation-bot Sonia-corporation-bot added the released Added when a Github/npm release was made label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Add a new feature/enhancement merge-into-master Will create a PR from develop to master released Added when a Github/npm release was made test Contains a change in a test file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Do not send release notes if the new version is smaller than the existing one
2 participants