Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant 'enable_eul_grid_forcing_reset' flag in virtual boundary forcing #155

Open
sy-cui opened this issue Aug 29, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request prio:low Low priority refactor Refactor existing codebase

Comments

@sy-cui
Copy link
Collaborator

sy-cui commented Aug 29, 2023

The VirtualBoundaryForcing class currently supports the enable_eul_grid_forcing_reset flag which, if True, set the Eulerian forcing field to zero before transfer the Lagrangian forces to Eulerian grid. This is justified by the Lagrangian-to-Eulerian communication kernel, which performs addition to the Eulerian field instead of replacement. Since this transfer is done exactly once every flow time step, the Eulerian forcing field should always be reset and thus the enable_eul_grid_forcing_reset flag should be True for all cases. Nonetheless, this resetting is invariably enforced in the flow simulator (_navier_stokes_with_forcing_time_step). Therefore, this flag along with the internal zeroing in VirtualBoundaryForcing is redundant.

@sy-cui sy-cui added enhancement New feature or request prio:low Low priority refactor Refactor existing codebase labels Aug 29, 2023
@sy-cui sy-cui self-assigned this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:low Low priority refactor Refactor existing codebase
Projects
None yet
Development

No branches or pull requests

1 participant