Merge branch 'master' into login-bang-method

Author: Spone

.devcontainer/Dockerfile

@@ -1,29 +1,15 @@
 {
   "name": "Ruby",
-  "build": {
-    "dockerfile": "Dockerfile"
-  },
+  "image": "mcr.microsoft.com/devcontainers/ruby",
 
-  // Configure tool-specific properties.
   "customizations": {
-    // Configure properties specific to VS Code.
     "vscode": {
-      // Add the IDs of extensions you want installed when the container is created.
       "extensions": [
-        "rebornix.Ruby"
+        "Shopify.ruby-lsp"
       ]
     }
   },
 
-  // Set the environment variables
-  // "runArgs": ["--env-file",".env"],
-
-  // Use 'forwardPorts' to make a list of ports inside the container available locally.
-  //   "forwardPorts": [],
-
-  // Use 'postCreateCommand' to run commands after the container is created.
   "postCreateCommand": "bash .devcontainer/postcreate.sh",
-
-  // Set `remoteUser` to `root` to connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
   "remoteUser": "vscode"
 }

.devcontainer/devcontainer.json

@@ -1,4 +1,4 @@
 #!/bin/bash
 
 bundle config set path vendor/bundle
-bundle install --jobs=1
+bundle install

.devcontainer/postcreate.sh

@@ -1,7 +1,4 @@
 Please ensure your pull request includes the following:
 
 - [ ] Description of changes
-- [ ] Update to CHANGELOG.md with short description and link to pull request
 - [ ] Changes have related RSpec tests that ensure functionality does not break
-
-<!-- For the changelog, please add your entry to the HEAD section. Do not create a new release header. -->

.github/PULL_REQUEST_TEMPLATE.md

@@ -10,26 +10,23 @@ on:
 
 jobs:
   test_matrix:
-
     runs-on: ubuntu-latest
-
     strategy:
       fail-fast: false
       matrix:
         ruby:
           - '3.2'
           - '3.3'
           - '3.4'
-
         rails:
           - '71'
           - '72'
           - '80'
+          - '81'
     env:
       BUNDLE_GEMFILE: gemfiles/rails_${{ matrix.rails }}.gemfile
-
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -38,9 +35,21 @@ jobs:
       - name: Run tests
         run: bundle exec rake spec
 
+  rubocop:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.4'
+          bundler-cache: true
+      - name: Run RuboCop
+        run: bundle exec rubocop .
+
   finish:
     runs-on: ubuntu-latest
-    needs: [ test_matrix ]
+    needs: [ test_matrix, rubocop ]
     steps:
       - name: Wait for status checks
         run: echo "All Green!"

.github/workflows/ruby.yml

@@ -1,9 +1,14 @@
 inherit_from: .rubocop_todo.yml
+plugins:
+  - rubocop-performance
+  - rubocop-rspec
 
 AllCops:
   Exclude:
     - 'lib/generators/sorcery/templates/**/*'
-  TargetRubyVersion: 2.6
+    - 'vendor/bundle/**/*'
+  TargetRubyVersion: 3.2
+  NewCops: enable
 
 # See: https://github.com/rubocop-hq/rubocop/issues/3344
 Style/DoubleNegation:
@@ -21,6 +26,7 @@ Metrics/BlockLength:
   Exclude:
     - 'lib/**/*'
     - 'spec/**/*'
+    - 'sorcery.gemspec'
 Layout/LineLength:
   Exclude:
     - 'lib/**/*'
@@ -45,11 +51,14 @@ Naming/AccessorMethodName:
   Exclude:
     - 'lib/**/*'
     - 'spec/**/*'
-Naming/PredicateName:
+Naming/PredicatePrefix:
   Exclude:
     - 'lib/**/*'
     - 'spec/**/*'
 Style/Documentation:
   Exclude:
     - 'lib/**/*'
     - 'spec/**/*'
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'lib/**/*'