Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Add support for aliases #13

Closed
zhouzi opened this issue Jul 12, 2017 · 5 comments
Closed

Add support for aliases #13

zhouzi opened this issue Jul 12, 2017 · 5 comments
Labels

Comments

@zhouzi
Copy link
Collaborator

zhouzi commented Jul 12, 2017

The search algorithm should also be able to match aliases. For example, Villentretenmerth is sometimes abbreviated "Vil", Yennefer called "Yen".

@zhouzi zhouzi added the idea label Jul 12, 2017
@zhouzi zhouzi mentioned this issue Jul 12, 2017
@zhouzi
Copy link
Collaborator Author

zhouzi commented Jul 12, 2017

Actually, the search algorithm will probably match abbreviations so I'm wondering if there are really cases where we'll want to add aliases. If not, this issue can be ignored and closed.

@Soreine
Copy link
Owner

Soreine commented Jul 22, 2017

Starting with #22 we will able to add multiple entries in the dictionary for the same card (that's what is done for plurals).

@Tri125
Copy link

Tri125 commented Jul 27, 2017

Look up https://github.com/PabloSzx/Gwent-Cards/blob/master/src/data/nicknames.json maybe you could ask Pablo if you could use his alias file.

@zhouzi
Copy link
Collaborator Author

zhouzi commented Jul 27, 2017

Thank you very much @Tri125, that is indeed an interesting list!

@zhouzi
Copy link
Collaborator Author

zhouzi commented Aug 6, 2017

Implemented in #31

@zhouzi zhouzi closed this as completed Aug 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants