Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CLI extensions so users can run custom inspectors & classifiers without forking. #503

Open
Will-Smith11 opened this issue Mar 8, 2024 · 0 comments
Labels
C-enhancement New feature or request D-2 Difficulty 2/5 (easy) P-2 Priority 2/3 (average criticality)

Comments

@Will-Smith11
Copy link
Collaborator

Will-Smith11 commented Mar 8, 2024

Description:

Currently, if someone wants to write custom inspectors for Brontes, they would need to fork the project and add their code directly. This approach isn't maintainable in the long term due to potential merge conflicts and the need to modify the database schema for storing newly classified data.

To improve the extensibility of Brontes, we want to add support for custom inspectors that can be defined and installed by users without requiring them to fork the project. This will enable users to create and use their own inspectors while keeping their codebase separate from the main Brontes repository.

Requirements

  • Implement a mechanism for users to define custom inspectors in their own repositories by implementing the existing Inspector trait.
  • Provide a way to install and load custom inspectors dynamically in Brontes.
  • Ensure that custom inspectors can be run alongside the built-in inspectors.
  • Modify the inspector initialization and execution logic to incorporate custom inspectors.
  • Maintain backward compatibility with the existing inspector system.

Additional Context|

See reth's CLI extension reth cli ext

LibEVM reth cli extension guide

@Will-Smith11 Will-Smith11 added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-2 Difficulty 2/5 (easy) P-2 Priority 2/3 (average criticality) and removed S-needs-triage This issue needs to be labelled labels Mar 8, 2024
@0xvanbeethoven 0xvanbeethoven changed the title feat: add extensibility to the CLI feat: Add CLI extensions so users can run custom inspectors & classifiers without forking. Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-2 Difficulty 2/5 (easy) P-2 Priority 2/3 (average criticality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants