Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balancer Vault #799

Open
2 of 3 tasks
0xvanbeethoven opened this issue Aug 20, 2024 · 1 comment
Open
2 of 3 tasks

Balancer Vault #799

0xvanbeethoven opened this issue Aug 20, 2024 · 1 comment
Labels
classifier-request A request to implement a new classifier S-needs-triage This issue needs to be labelled

Comments

@0xvanbeethoven
Copy link
Contributor

Protocol Name

Balancer

Protocol Description

Balancer Vault:
See: 0xBA12222222228d8Ba445958a75a0704d566BF2C8

Functions to Support

batchSwap()
flashLoan()
swap()

Normalized Action Types

NormalizedBatch
NormalizedFlashloan
NormalizedSwap

Is it a Proxy?

  • Yes
  • No

Discovery Mechanism Requirements

Unsure if necesary

Additional Context

See:
https://etherscan.io/address/0xba12222222228d8ba445958a75a0704d566bf2c8#code

Docs:
https://docs.balancer.fi/concepts/vault/#gas-efficient-batch-swaps
https://docs.balancer.fi/concepts/vault/swaps.html

Code of Conduct

  • I agree to follow the Code of Conduct.
@0xvanbeethoven 0xvanbeethoven added S-needs-triage This issue needs to be labelled classifier-request A request to implement a new classifier labels Aug 20, 2024
@mendesfabio
Copy link

hey this is Fábio from Balancer - very excited about brontes and looking forward to try it!

I thought about creating an issue to discuss / try to understand some things but maybe I can use this one. My first question is: doesn't brontes already have a Balancer V2 classifier for the functions you listed? 🤔 what I'm missing?

Besides, I would like to point out there are some swaps on Balancer V2 that are actually single-side add/remove liquidity - could that cause any issues? I don't see any handling for it but what happens is you have a swap where either token in or token out is the LP token itself and that probably shouldn't be classified as NormalizedSwap

Last, and very minor detail, but I think V2 pool registrations should be moved to discovery.rs? From a quick look other classifiers follow this and only Balancer is incosistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classifier-request A request to implement a new classifier S-needs-triage This issue needs to be labelled
Projects
None yet
Development

No branches or pull requests

2 participants