Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Idempotent Test #13

Open
apmarshall opened this issue Feb 19, 2023 · 0 comments
Open

Fix Idempotent Test #13

apmarshall opened this issue Feb 19, 2023 · 0 comments

Comments

@apmarshall
Copy link
Member

The goal of the idempotent test is to let us know when we are following bad practices for ansible playbooks. Unfortunately, it is impossible for shell commands to be truly idempotent and there are other things that inevitably change (ie, git clones) or could easily change and not be an indicator of bad practice (ie, if an update to a package happened to come out between runs).

To improve the situation, we need to do two things:

  1. Label tests that cannot be reliably made idempotent with the tag “not-idempotent” so that they are skipped by this test.
  2. Add changed_when and failed_when fields to shell command tasks, which will give them something resembling idempotent status.

This is relatively low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant