Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PrettyPrinter] Stack Trace: Use errorMethodCount only if an error was provided #6

Closed
Bungeefan opened this issue Feb 26, 2023 · 1 comment
Closed

[PrettyPrinter] Stack Trace: Use errorMethodCount only if an error was provided #6

Bungeefan opened this issue Feb 26, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
2.0.0

Comments

@Bungeefan
Copy link
Member

I am creating this issue to pick up this pull request: simc/logger#139

Summary

PrettyPrinter should use errorMethodCount for Stack Traces only if an error was provided, otherwise it should use methodCount.

Voting

Please add the 👍 reaction, if you would like to see this implemented.
@Bungeefan Bungeefan added enhancement New feature or request help wanted Extra attention is needed labels Feb 26, 2023
@Bungeefan Bungeefan added this to the 2.0.0 milestone May 10, 2023
@cedvdb
Copy link

cedvdb commented Nov 18, 2023

hum error level should use errorMethodCount tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@cedvdb @Bungeefan