Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue: Improve CI #188

Closed
5 tasks done
preston-evans98 opened this issue Apr 21, 2023 · 7 comments · Fixed by #197 or #559
Closed
5 tasks done

Tracking Issue: Improve CI #188

preston-evans98 opened this issue Apr 21, 2023 · 7 comments · Fixed by #197 or #559
Labels
ci Everyting related to CI (Continuous integration)

Comments

@preston-evans98
Copy link
Member

preston-evans98 commented Apr 21, 2023

Comprehensiveness

Performance

CI runtime has gone from 30 minutes to 10 minutes. (Thanks @citizen-stig for switching to sccachein #197). We would like to reduce this time even further.

Some Ideas (TODO: expand, evaluate tradeoffs)

  • Separate sov-state into two crates: one which provides the API and one which provides the implementation. This would let us avoid depending on RocksDB everywhere.
  • Move the sov-modules-macros tests into their own crate instead of relying on trybuild so that they can build in parallel with other items instead of sequentially.

Thanks @bkolad for the suggestion

@preston-evans98
Copy link
Member Author

@citizen-stig Suggests that sccache might alleviate the compilation bottleneck.

@citizen-stig
Copy link
Member

Checked running time of the tests and we are fine, except for 2 tests, which are big offenders:

Screenshot 2023-04-24 at 20 29 54

But still they should not lead to 20-30 minutes time of the CI

@citizen-stig citizen-stig linked a pull request Apr 25, 2023 that will close this issue
@citizen-stig
Copy link
Member

Some tips recommended by @bkolad :

https://www.youtube.com/watch?v=xUH-4y92jPg

@preston-evans98 preston-evans98 changed the title Improve CI Tracking Issue: Improve CI Apr 26, 2023
@citizen-stig
Copy link
Member

Also there were some comments in #439 in description

@citizen-stig citizen-stig added the ci Everyting related to CI (Continuous integration) label Jun 28, 2023
@citizen-stig
Copy link
Member

@neysofu you might be interested in this one.

@neysofu
Copy link
Member

neysofu commented Oct 18, 2023

I would propose we close this –it's outdated at this point– and create single issues for more specific improvements we want to make.

@preston-evans98
Copy link
Member Author

Agreed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Everyting related to CI (Continuous integration)
Projects
None yet
3 participants