Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init_chain should return the genesis root hash and have post genesis hooks #555

Closed
theochap opened this issue Jul 24, 2023 · 2 comments · Fixed by #598
Closed

Init_chain should return the genesis root hash and have post genesis hooks #555

theochap opened this issue Jul 24, 2023 · 2 comments · Fixed by #598
Assignees

Comments

@theochap
Copy link
Contributor

theochap commented Jul 24, 2023

Context
Currently, the init_chain function does not return the initial root hash after genesis. This forces us to use hacks and process an empty blob such as in the demo-rollup. Moreover, the rollup needs to be able to get the initial state hash to properly initialize the chain state.

Solution

  • Return the initial root hash after genesis in the init_chain function.
  • Hook on the exit of the init_chain function to be able to store the initial root hash. That would be some sort of genesis_hook.
@citizen-stig
Copy link
Member

@theochap could you please confirm if this issue is still have left things to do?

@citizen-stig citizen-stig linked a pull request Aug 14, 2023 that will close this issue
@citizen-stig
Copy link
Member

Already one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants