Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockBlob takes unnecessary generic. #724

Closed
bkolad opened this issue Aug 24, 2023 · 0 comments · Fixed by #749
Closed

MockBlob takes unnecessary generic. #724

bkolad opened this issue Aug 24, 2023 · 0 comments · Fixed by #749
Assignees
Labels
Small Use this label for quick cleanup and maintenance tasks

Comments

@bkolad
Copy link
Member

bkolad commented Aug 24, 2023

Summary

MockBlob takes unnecessary generic:

pub struct MockBlob<A> {
    address: A,
    hash: [u8; 32],
    data: CountedBufReader<Bytes>,
}

The address in MockBlob should be set to MockAddress, unfortunately, some of our tests use CelestiaAddress.
The task is:

  1. Fix tests to use MockAddress instead of CelestiaAddress
  2. Remove generic A from mock blob.
@bkolad bkolad added the Small Use this label for quick cleanup and maintenance tasks label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Small Use this label for quick cleanup and maintenance tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant