✨ Improve CEL expression evaluation #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve CEL expression evaluation by adding further conditions and events. Make the error handling more elaborate to differentiate errors from expected results Signed-off-by: janiskemper <janis.kemper@syself.com>
guettli
reviewed
Sep 3, 2024
| csov1alpha1.CompileCELExpressionFailedReason, | ||
| "failed to compile CEL expression: %s, %s", waitCondition.Conditions, iss.Err(), | ||
| ) | ||
|
|
There was a problem hiding this comment.
@janiskemper I would add a comment here, why you don't return an error.
guettli
reviewed
Sep 3, 2024
Comment on lines
+1199
to
+1202
| "object(%s/%s) from dynamic client for CEL expression is not found: %s", object.Namespace, object.Name, err.Error(), | ||
| ) | ||
|
|
||
| return false, false, fmt.Errorf("failed to get object(%s/%s) from dynamic client for CEL expression: %w", object.Namespace, object.Name, err) |
There was a problem hiding this comment.
@janiskemper is there a reason why both strings are different?
Suggestion:
err2 := fmt.fmt.Errorf("failed to get object(%s/%s) from dynamic client for CEL expression: %w", object.Namespace, object.Name, err)
conditions.MarkFalse(..., err2.Error())
return false, false, err2Just a comment, not merge blocking.
guettli
reviewed
Sep 3, 2024
| "failed to evaluate the Ast and environment against the input vars for CEL expression: %s", err.Error(), | ||
| ) | ||
|
|
||
| return false, false, fmt.Errorf("failed to evaluate the Ast and environment against the input vars for CEL expression: %w", err) |
There was a problem hiding this comment.
@janiskemper the same err2-pattern could be used here.
guettli
reviewed
Sep 3, 2024
|
yes, by manipulating the clusteraddon.yaml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improve CEL expression evaluation by adding further conditions and events. Make the error handling more elaborate to differentiate errors from expected results
Which issue(s) this PR fixes:
Fixes #210
TODOs: