Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/mutable_appearance should have more vars than /image + opacity #186

Closed
Kaiochao opened this issue May 16, 2020 · 3 comments
Closed

/mutable_appearance should have more vars than /image + opacity #186

Kaiochao opened this issue May 16, 2020 · 3 comments
Labels
Milestone

Comments

@Kaiochao
Copy link

Kaiochao commented May 16, 2020

mutable_appearance/parent_type = path!(/image);
mutable_appearance/var/opacity; // inherited from /mob according to the docs

@SpaceManiac
Copy link
Owner

like what

@Kaiochao
Copy link
Author

Kaiochao commented May 16, 2020

Well, just from difference in what the docs show for vars (mutable_appearance) and vars (image):

/mutable_appearance vars that /image isn't documented to have:

  • density
  • desc
  • gender
  • invisibility
  • layer
  • luminosity
  • animate_movement
  • mouse_over_pointer
  • mouse_drag_pointer
  • mouse_drop_pointer
  • mouse_drop_zone
  • mouse_opacity
  • name
  • opacity (got this one already, nice)
  • screen_loc
  • suffix
  • verbs
  • vis_flags

/image vars that /mutable_appearance isn't documented to have:

  • loc
  • override
  • render_source
  • render_target
  • vis_contents
  • x
  • y
  • z
  • type
  • tag
  • parent_type

@SpaceManiac
Copy link
Owner

SpaceManiac commented Jun 5, 2020

The docs have this to say:

The /mutable_appearance datum is technically a descendant of /image, but this is only for convenience, and should not be relied on for any other purpose as it is subject to change in future versions.

I have to strike a balance between implementing DM as documented and implementing DM as actually used. In this case I will be making available the same set of vars on /image and on /mutable_appearance that the DM compiler does.

@SpaceManiac SpaceManiac added the bug label Jun 5, 2020
@SpaceManiac SpaceManiac added this to the suite v1.5 milestone Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants