Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsed Columns do not add margin in between #551

Closed
jonambas opened this issue Jul 16, 2020 · 0 comments · Fixed by #552
Closed

Collapsed Columns do not add margin in between #551

jonambas opened this issue Jul 16, 2020 · 0 comments · Fixed by #552
Labels
bug

Comments

@jonambas
Copy link
Contributor

🐛 Bug report

Current Behavior

Columns that are collapsed via collapseBelow do not use the space prop as vertical margin between the collapsed columns

Expected behavior

The space prop should apply vertical margin

Reproducible example

See storybook example – vertical margin is added through the child not the Columns component

Suggested solution(s)

Modify Columns and Column to use the space prop to add vertical margins

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves #551 - Adds correct vertical margin between collapsed columns SparkPost/matchbox
1 participant
@jonambas