Skip to content

Commit 1083e23

Browse files
committed
Updates a budget to about double (just to put something in there) and adds the check against the budget back into the lighthouse workflow.
1 parent 9f72af6 commit 1083e23

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

.github/workflows/lighthouse.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,5 @@ jobs:
4646
urls: |
4747
${{ steps.netlify.outputs.url }}
4848
${{ steps.netlify.outputs.url }}/momentum/
49-
# TODO ERY: We will need to add this back in the future, but we need to deliberate on what we find an acceptable lighthouse budget to be
50-
# budgetPath: ./lighthouse-budget.json
49+
budgetPath: ./lighthouse-budget.json
5150
uploadArtifacts: true

.gitignore

+4-1
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,7 @@ yarn-error.log*
4040
.env
4141

4242
# Auto generated images
43-
public/content
43+
public/content
44+
45+
# Netlify
46+
/.netlify/

lighthouse-budget.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,23 @@
88
},
99
{
1010
"metric": "first-meaningful-paint",
11-
"budget": 2000
11+
"budget": 5000
1212
}
1313
],
1414
"resourceSizes": [
1515
{
1616
"resourceType": "script",
17-
"budget": 150
17+
"budget": 500
1818
},
1919
{
2020
"resourceType": "total",
21-
"budget": 500
21+
"budget": 1000
2222
}
2323
],
2424
"resourceCounts": [
2525
{
2626
"resourceType": "third-party",
27-
"budget": 100
27+
"budget": 200
2828
}
2929
]
3030
}

0 commit comments

Comments
 (0)