angular#1199

Suggested approach for supporting numerical true/false values in checkbox inputs.

Author: simonsparks

src/ng/directive/input.js

@@ -641,11 +641,8 @@ function radioInputType(scope, element, attr, ctrl) {
 }
 
 function checkboxInputType(scope, element, attr, ctrl) {
-  var trueValue = attr.ngTrueValue,
-      falseValue = attr.ngFalseValue;
-
-  if (!isString(trueValue)) trueValue = true;
-  if (!isString(falseValue)) falseValue = false;
+  var trueValue = typedValue(attr.ngTrueValue, true),
+      falseValue = typedValue(attr.ngFalseValue, false);
 
   element.on('click', function() {
     scope.$apply(function() {
@@ -666,6 +663,13 @@ function checkboxInputType(scope, element, attr, ctrl) {
   });
 }
 
+function typedValue(val, defaultVal) {
+  return isString(val)
+    ? !isNaN(parseFloat(val)) && isFinite(val)
+      ? parseFloat(val)
+      : val
+    : defaultVal;
+}
 
 /**
  * @ngdoc directive

test/ng/directive/inputSpec.js

@@ -876,7 +876,7 @@ describe('input', function() {
     });
 
 
-    it('should allow custom enumeration', function() {
+    it('should allow custom string enumeration', function() {
       compileInput('<input type="checkbox" ng-model="name" ng-true-value="y" ' +
           'ng-false-value="n">');
 
@@ -902,6 +902,31 @@ describe('input', function() {
       expect(scope.name).toEqual('n');
     });
 
+      it('should allow custom numerical enumeration', function() {
+        compileInput('<input type="checkbox" ng-model="name" ng-true-value="1" ' +
+            'ng-false-value="0">');
+
+        scope.$apply(function() {
+          scope.name = 1;
+        });
+        expect(inputElm[0].checked).toBe(true);
+
+        scope.$apply(function() {
+          scope.name = 0;
+        });
+        expect(inputElm[0].checked).toBe(false);
+
+        scope.$apply(function() {
+          scope.name = 'something else';
+        });
+        expect(inputElm[0].checked).toBe(false);
+
+        browserTrigger(inputElm, 'click');
+        expect(scope.name).toEqual(1);
+
+        browserTrigger(inputElm, 'click');
+        expect(scope.name).toEqual(0);
+      });
 
     it('should be required if false', function() {
       compileInput('<input type="checkbox" ng:model="value" required />');