Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] make chromium.zip fails because tsc errors #105

Closed
ernestocarrasco-em opened this issue May 22, 2023 · 1 comment · Fixed by #111
Closed

[BUG] make chromium.zip fails because tsc errors #105

ernestocarrasco-em opened this issue May 22, 2023 · 1 comment · Fixed by #111
Labels
bug Something isn't working

Comments

@ernestocarrasco-em
Copy link

Environment

  • chromium Version: 113
  • puppeteer / puppeteer-core Version: latest
  • Node.js Version: 16.x and 18.x
  • Lambda / GCF Runtime: nodejs 16.x

Expected Behavior

  • chromium.zip should be created successfully

Current Behavior

  • Got some tcs error executing make chromium.zip
npm install --fund=false --package-lock=false

up to date, audited 51 packages in 594ms

found 0 vulnerabilities
npm run build

> @sparticuz/chromium@113.0.1 build
> rm -rf build && tsc -p tsconfig.json

source/index.ts:374:1 - error TS1203: Export assignment cannot be used when targeting ECMAScript modules. Consider using 'export default' or another module format instead.

374 export = Chromium;
    ~~~~~~~~~~~~~~~~~~

source/lambdafs.ts:75:1 - error TS1203: Export assignment cannot be used when targeting ECMAScript modules. Consider using 'export default' or another module format instead.

75 export = LambdaFS;
   ~~~~~~~~~~~~~~~~~~


Found 2 errors in 2 files.

Errors  Files
     1  source/index.ts:374
     1  source/lambdafs.ts:75
make: *** [chromium.zip] Error 2

Steps to Reproduce

cd chromium
make chromium.zip

Possible Solution

  • Fix tcs errors in source/index.ts:374 and source/lambdafs.ts:75
@ernestocarrasco-em ernestocarrasco-em added the bug Something isn't working label May 22, 2023
@Sparticuz
Copy link
Owner

fixed in #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants