Sre crash when it build in some locales

[BlueCat0]

When I build sre from my laptop, it crash when load rule file.
I checked it and found the action file load earlier than base file, which will cause crash here.

speech-rule-engine/ts/rule_engine/speech_rule_engine.ts

Lines 820 to 826 in cc46b71

	function storeFactory(set: RulesJson) {
	const name = `${set.locale}.${set.modality}.${set.domain}`;
	if (set.kind === 'actions') {
	const store = stores.get(name);
	store.parse(set);
	return store;
	}

I found lib/mathmaps was createad by makefiles

speech-rule-engine/Makefile

Lines 71 to 86 in cc46b71

	$(LOC_DST): $(MINI_DST)
	@echo "Creating mappings for locale `basename $@ .json`."
	@echo '{' > $@
	@for dir in $(MAPS); do\
	if [ -d $(JSON_SRC)/`basename $@ .json`/$$dir ]; then \
	for i in $(JSON_SRC)/`basename $@ .json`/$$dir/*.min; do\
	echo '"'`basename $@ .json`/$$dir/`basename $$i`'": ' >> $@; \
	cat $$i >> $@; \
	echo ',' >> $@; \
	done; \
	fi; \
	done
	@sed '$$d' $@ > $@.tmp
	@echo '}' >> $@.tmp
	@echo '' >> $@.tmp
	@mv $@.tmp $@

it should be noticed that for in loop in bash not guarantee alphabetical order, it depends on locale.

in my case, when LANG was set to zh_CN.UTF-8, the merged json file order will cause crash.

"base/rules/clearspeak_base_actions.min"
"base/rules/clearspeak_base.min"

and when set LC_COLLATE to C, it will has same order with released file.

"base/rules/clearspeak_base.min"
"base/rules/clearspeak_base_actions.min"

add this env to makefile will help.

[zorkow]

Thanks for reporting this. I was not aware of the bash feature.